Handle bridge config fetch errors #6961
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:S
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
![roomote[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Thank you for your contribution! I've reviewed the changes and found that they correctly address the issue of preventing extension obstruction from cloud service errors. The error handling approach is sound, though I have some suggestions for improvement.
| if (this.enableTaskBridge && CloudService.hasInstance()) { | ||
| if (!this.taskBridgeService) { | ||
| const bridgeConfig = await CloudService.instance.cloudAPI?.bridgeConfig() | ||
| const bridgeConfig = await CloudService.instance.cloudAPI?.bridgeConfig().catch(() => undefined) |
Contributor
There was a problem hiding this comment.
Same suggestion here - add error logging for consistency:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Roo Code Cloud http errors shouldn't obstruct the extension.
Important
Add error handling for bridge configuration fetches to prevent extension obstruction in
Task.ts,ClineProvider.ts, andextension.ts..catch(() => undefined)tobridgeConfig()calls inTask.ts(startTask,resumeTaskFromHistory) andClineProvider.ts(handleRemoteControlToggle)..catch(() => undefined)tobridgeConfig()call inextension.tsduringuser-infoevent handling.bridgeConfig()returns undefined inClineProvider.tsandextension.ts.This description was created by
for 3441116. You can customize this summary. It will automatically update as commits are pushed.