fix: remove temperature parameter for GPT-5 models #6966
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![roomote[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
GPT-5 no longer supports the temperature parameter in its API. This commit removes the temperature field from GPT-5 requests to prevent API errors when using LiteLLM or other proxies. Fixes #6965
dosubot
bot
added
size:S
| @@ -273,7 +273,7 @@ export class OpenAiNativeHandler extends BaseProvider implements SingleCompletio | |||
| stream: boolean | |||
| reasoning?: { effort: ReasoningEffortWithMinimal; summary?: "auto" } | |||
| text?: { verbosity: VerbosityLevel } | |||
| temperature?: number | |||
| // temperature parameter removed - GPT-5 no longer supports it | |||
There was a problem hiding this comment.
Minor style inconsistency: This comment uses a different format than the line comment on line 292. Could we standardize on one comment style for consistency?
| // TODO: Add a `supportsTemperature` field to the model info. | ||
| if (modelId.startsWith("o1") || modelId.startsWith("o3-mini")) { | ||
| if (modelId.startsWith("o1") || modelId.startsWith("o3-mini") || modelId.startsWith("gpt-5")) { |
There was a problem hiding this comment.
The existing TODO mentions adding a supportsTemperature field. Since we're now handling GPT-5 alongside o1 and o3-mini, would it be worth prioritizing this refactor to make the temperature support more explicit in the model definitions?
hannesrudolph
added
the
Issue/PR - Triage
|
Closing in favor of #6969 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an issue where GPT-5 models were sending the temperature parameter, which is no longer supported by the GPT-5 API. This was causing errors when using LiteLLM or other proxy services.
Changes
temperatureparameter from GPT-5 Responses API requests inopenai-native.tsmodel-params.tsto exclude temperature for GPT-5 models (similar to o1 and o3-mini models)Testing
openai-native.spec.tsandmodel-params.spec.tsRelated Issue
Fixes #6965
Impact
This change ensures that GPT-5 models work correctly with LiteLLM and other proxy services that strictly enforce the GPT-5 API specification.
Important
Remove unsupported
temperatureparameter for GPT-5 models in API requests and tests.temperatureparameter from GPT-5 API requests inopenai-native.ts.model-params.tsto excludetemperaturefor GPT-5 models.openai-native.spec.tsto reflect removal oftemperatureparameter for GPT-5 models.This description was created by
for 10eeece. You can customize this summary. It will automatically update as commits are pushed.