Skip to content

Conversation

@requesty-JohnCosta27
Copy link
Contributor

@requesty-JohnCosta27 requesty-JohnCosta27 commented Aug 12, 2025

Related GitHub Issue

Closes: #6983

Description

Adds the ability to add custom base URLs for Requesty provider

Test Procedure

  1. Choose Requesty as your provider
  2. Click "Use custom base URL"
  3. Enter some base URL.

Pre-Submission Checklist

  • Issue Linked: This PR is linked to an approved GitHub Issue (see "Related GitHub Issue" above).
  • Scope: My changes are focused on the linked issue (one major feature/fix per PR).
  • Self-Review: I have performed a thorough self-review of my code.
  • Testing: New and/or updated tests have been added to cover my changes (if applicable).
  • Documentation Impact: I have considered if my changes require documentation updates (see "Documentation Updates" section below).
  • Contribution Guidelines: I have read and agree to the Contributor Guidelines.

Screenshots / Videos

Screenshot 2025-08-12 at 12 03 29

Documentation Updates

Additional Notes

Get in Touch


Important

Add support for custom base URLs in Requesty provider with UI and test updates.

  • Behavior:
    • Adds requestyBaseUrl option to requestySchema in provider-settings.ts for custom base URLs.
    • Updates RequestyHandler in requesty.ts to use requestyBaseUrl if provided, defaulting to "https://router.requesty.ai/v1".
    • Adds checkbox and input field in Requesty.tsx for custom URL entry.
  • Testing:
    • Adds test in requesty.spec.ts to verify custom base URL functionality.
  • UI and Translations:
    • Updates settings.json in multiple locales to include strings for custom base URL feature.
    • Adds checkbox and input field for custom URL in Requesty.tsx.

This description was created by Ellipsis for baed0b7. You can customize this summary. It will automatically update as commits are pushed.

@requesty-JohnCosta27 requesty-JohnCosta27 marked this pull request as draft August 12, 2025 10:13
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. enhancement New feature or request labels Aug 12, 2025
Copy link
Contributor

@roomote roomote bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! I've reviewed the changes and found several issues that need attention before this can be merged.

The main concerns are:

  1. Missing required GitHub issue link
  2. Missing internationalization for UI text
  3. Potential state management issues in the UI component

Please address the inline comments below.

@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Aug 12, 2025
@requesty-JohnCosta27 requesty-JohnCosta27 force-pushed the adding-requesty-base-url branch 2 times, most recently from c00bb1b to ab98210 Compare August 12, 2025 10:58
@requesty-JohnCosta27 requesty-JohnCosta27 marked this pull request as ready for review August 12, 2025 11:05
requesty-JohnCosta27 and others added 3 commits August 12, 2025 12:12
Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>
Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>
Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 12, 2025
@mrubens
Copy link
Collaborator

mrubens commented Aug 12, 2025

@roomote-agent can you switch into translate mode and add the missing Polish translation?

@roomote
Copy link
Contributor

roomote bot commented Aug 12, 2025

Hi @mrubens! I see your request to add the missing Polish translations for the new Requesty custom base URL feature. I'll switch to translate mode and add those translations right away.

@roomote
Copy link
Contributor

roomote bot commented Aug 12, 2025

Hi @mrubens! I've successfully added the missing Polish translations for the Requesty custom base URL feature.

Changes made:

  1. ✅ Added Polish translation for getRequestyBaseUrl: "Bazowy URL"
  2. ✅ Added Polish translation for requestyUseCustomBaseUrl: "Użyj niestandardowego bazowego URL"
  3. ✅ Also fixed incorrect Turkish translations that were using Dutch text

The translation validation script now shows all translations are complete. The CI checks should pass once they re-run with the latest changes.

Commits added:

  • feat: add Polish translations for Requesty custom base URL feature
  • fix: correct Turkish translations for Requesty custom base URL feature

@mrubens
Copy link
Collaborator

mrubens commented Aug 12, 2025

Moved to #6992

@mrubens mrubens closed this Aug 12, 2025
@github-project-automation github-project-automation bot moved this from Triage to Done in Roo Code Roadmap Aug 12, 2025
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Aug 12, 2025
@requesty-JohnCosta27
Copy link
Contributor Author

Moved to #6992

Thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Add custom URL option for Requesty provider

3 participants