-
Notifications
You must be signed in to change notification settings - Fork 2.6k
adding option to have a custom requesty URL #6982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding option to have a custom requesty URL #6982
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution! I've reviewed the changes and found several issues that need attention before this can be merged.
The main concerns are:
- Missing required GitHub issue link
- Missing internationalization for UI text
- Potential state management issues in the UI component
Please address the inline comments below.
c00bb1b to
ab98210
Compare
adding locales fix fix fix
ab98210 to
baed0b7
Compare
Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>
Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>
Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>
|
@roomote-agent can you switch into translate mode and add the missing Polish translation? |
|
Hi @mrubens! I see your request to add the missing Polish translations for the new Requesty custom base URL feature. I'll switch to translate mode and add those translations right away. |
|
Hi @mrubens! I've successfully added the missing Polish translations for the Requesty custom base URL feature. Changes made:
The translation validation script now shows all translations are complete. The CI checks should pass once they re-run with the latest changes. Commits added:
|
|
Moved to #6992 |
Thanks! :) |
Related GitHub Issue
Closes: #6983
Description
Adds the ability to add custom base URLs for Requesty provider
Test Procedure
Pre-Submission Checklist
Screenshots / Videos
Documentation Updates
Additional Notes
Get in Touch
Important
Add support for custom base URLs in Requesty provider with UI and test updates.
requestyBaseUrloption torequestySchemainprovider-settings.tsfor custom base URLs.RequestyHandlerinrequesty.tsto userequestyBaseUrlif provided, defaulting to "https://router.requesty.ai/v1".Requesty.tsxfor custom URL entry.requesty.spec.tsto verify custom base URL functionality.settings.jsonin multiple locales to include strings for custom base URL feature.Requesty.tsx.This description was created by
for baed0b7. You can customize this summary. It will automatically update as commits are pushed.