Skip to content

Conversation

@mrubens
Copy link
Collaborator

@mrubens mrubens commented Feb 1, 2025

Follow-up to #696 to move the checkbox to the MCP view
Screenshot 2025-01-31 at 11 42 31 PM


Important

Move "Enable MCP Server Creation" checkbox from SettingsView.tsx to McpView.tsx for better context placement.

  • UI Changes:
    • Move "Enable MCP Server Creation" checkbox from SettingsView.tsx to McpView.tsx.
    • Add explanatory text for the checkbox in McpView.tsx.
  • State Management:
    • Use enableMcpServerCreation and setEnableMcpServerCreation in McpView.tsx.
    • Remove enableMcpServerCreation related code from SettingsView.tsx.

This description was created by Ellipsis for 5abf5e3. It will automatically update as commits are pushed.

@changeset-bot
Copy link

changeset-bot bot commented Feb 1, 2025

⚠️ No Changeset found

Latest commit: 5abf5e3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

<div style={{ marginBottom: 15 }}>
<VSCodeCheckbox
checked={enableMcpServerCreation}
onChange={(e: any) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid using any for event types. Use React.ChangeEvent<HTMLInputElement> for better type safety.

Suggested change
onChange={(e: any) => {
onChange={(e: React.ChangeEvent<HTMLInputElement>) => {

This is from our Development Standards: https://www.notion.so/Development-Standards-59febcf8ead647fd9c2ec3f60c22f3df?pvs=4#11869ad2d5818051ae9cefd92c3aac2b

@mrubens mrubens merged commit 83fd05c into main Feb 1, 2025
7 checks passed
@mrubens mrubens deleted the move_mcp_creation_checkbox_to_mcp_screen branch February 1, 2025 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants