-
Notifications
You must be signed in to change notification settings - Fork 2.6k
chore: add changeset for v3.25.12 #7018
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for preparing the v3.25.12 changeset! I've reviewed the changes and have some suggestions for improvement to ensure consistency and traceability.
|
|
||
| - Update: Claude Sonnet 4 context window configurable to 1 million tokens in Anthropic provider (thanks @daniel-lxs!) | ||
| - Add: Minimal reasoning support to OpenRouter (thanks @daniel-lxs!) | ||
| - Fix: Add configurable API request timeout for local providers (#6521 by @dabockster, PR by @app/roomote) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed the attribution format varies throughout the file. Some entries use "thanks @username!" while others use "by @username, PR by @username". Would it be better to standardize this for consistency?
For example, you could use:
- "(#issue by @reporter, PR #number by @author)" for all entries with issues/PRs
- "(thanks @contributor!)" for direct contributions
| - Add: New Chutes provider models (#6698 by @fstandhartinger, PR by @app/roomote) | ||
| - Add: OpenAI gpt-oss models to Amazon Bedrock dropdown (#6752 by @josh-clanton-powerschool, PR by @app/roomote) | ||
| - Fix: Correct tool repetition detector to not block first tool call when limit is 1 (#6834 by @NaccOll, PR by @app/roomote) | ||
| - Fix: Improve checkpoint service initialization handling (thanks @NaccOll!) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These entries are missing PR numbers, while lines 7-12 include them. Including PR numbers for all entries would improve traceability. Could you add the PR numbers if they exist?
| - Add: Task expand and collapse translations (thanks @app/roomote!) | ||
| - Update: Exclude GPT-5 models from 20% context window output token cap (thanks @app/roomote!) | ||
| - Fix: Truncate long model names in model selector to prevent overflow (thanks @app/roomote!) | ||
| - Add: Requesty base url support (thanks @requesty-JohnCosta27!) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is "Requesty" the correct spelling here? Just want to confirm this isn't a typo for another provider name.
| @@ -0,0 +1,18 @@ | |||
| --- | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The filename doesn't follow the typical changeset naming convention (usually random names like ). Is this intentional for release changesets? If so, you might want to ensure this doesn't conflict with the changeset tooling.
| "roo-cline": patch | ||
| --- | ||
|
|
||
| - Update: Claude Sonnet 4 context window configurable to 1 million tokens in Anthropic provider (thanks @daniel-lxs!) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider grouping these changes by category (Features/Additions, Fixes, Updates) to improve readability in the final changelog. For example:
Important
Version 3.25.12 introduces updates, new models, and fixes including configurable context windows, new provider models, and improved initialization handling.
This description was created by
for e009ee5. You can customize this summary. It will automatically update as commits are pushed.