Skip to content

Don't run the integration-test job if there's no API key #703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cte merged 5 commits into from
Feb 1, 2025
+20 −10
Merged

Don't run the integration-test job if there's no API key #703

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b7cd98d
Don't run the `integration-test` job if there's no API key
cte Feb 1, 2025
17fb94c
Secrets can't be used in conditionals, apparently
cte Feb 1, 2025
de7f67f
One more attempt
cte Feb 1, 2025
ab2dd09
Test what happens if the secret does not exist
cte Feb 1, 2025
5c8df59
Confirmed that `check-openrouter-api-key` works; remove debugging
cte Feb 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 20 additions & 10 deletions .github/workflows/code-qa.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,11 +43,25 @@ jobs:
- name: Run unit tests
run: npm test

check-openrouter-api-key:
runs-on: ubuntu-latest
outputs:
exists: ${{ steps.openrouter-api-key-check.outputs.defined }}
steps:
- name: Check if OpenRouter API key exists
id: openrouter-api-key-check
shell: bash
run: |
if [ "${{ secrets.OPENROUTER_API_KEY }}" != '' ]; then
echo "defined=true" >> $GITHUB_OUTPUT;
else
echo "defined=false" >> $GITHUB_OUTPUT;
fi

integration-test:
strategy:
matrix:
os: [ubuntu-latest] # macos-latest, windows-latest
runs-on: ${{ matrix.os }}
runs-on: ubuntu-latest
needs: [check-openrouter-api-key]
if: needs.check-openrouter-api-key.outputs.exists == 'true'
steps:
- name: Checkout code
uses: actions/checkout@v4
Expand All @@ -58,11 +72,7 @@ jobs:
cache: 'npm'
- name: Create env.integration file
run: echo "OPENROUTER_API_KEY=${{ secrets.OPENROUTER_API_KEY }}" > .env.integration
- name: Check env.integration file
run: cat .env.integration
- name: Install dependencies
run: npm run install:all
- run: xvfb-run -a npm run test:integration
if: runner.os == 'Linux'
- run: npm run test:integration
if: runner.os != 'Linux'
- name: Run integration tests
run: xvfb-run -a npm run test:integration
Loading