Flex working1 #7045
Flex working1 #7045
Conversation
dosubot
bot
added
the
size:L
![roomote[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
There was a problem hiding this comment.
Thank you for your contribution! I've reviewed the changes and found several issues that need attention before this can be merged.
The main concerns are:
- Missing linked GitHub issue (required by contribution guidelines)
- Unrelated changes mixed with the flex pricing feature
- Debug code left in production
- Type safety issues that should be addressed
Please see my inline comments for specific suggestions.
|
|
||
| const isSupported = useMemo(() => { | ||
| const supported = !!effectiveModelId && FLEX_COMPATIBLE_MODELS.some((m) => effectiveModelId.includes(m)) | ||
| console.log("[DEBUG] Service tier supported check:", { effectiveModelId, supported, FLEX_COMPATIBLE_MODELS }) |
There was a problem hiding this comment.
Debug console.log should be removed from production code. Consider using a proper logging utility if debugging is needed during development.
| ): number { | ||
| const cacheCreationInputTokensNum = cacheCreationInputTokens || 0 | ||
| const cacheReadInputTokensNum = cacheReadInputTokens || 0 | ||
| const nonCachedInputTokens = Math.max(0, inputTokens - cacheCreationInputTokensNum - cacheReadInputTokensNum) | ||
|
|
||
| // If flex tier selected and model exposes flexPrice, override pricing fields. | ||
| const pricingInfo = | ||
| serviceTier === "flex" && (modelInfo as any).flexPrice |
There was a problem hiding this comment.
The use of 'as any' bypasses TypeScript's type safety. Could we properly type the flexPrice property in the ModelInfo interface instead?
| @@ -91,7 +91,6 @@ export function Features() { | |||
| y: 0, | |||
| transition: { | |||
| duration: 0.6, | |||
| ease: [0.21, 0.45, 0.27, 0.9], | |||
| }, | |||
There was a problem hiding this comment.
These animation easing changes seem unrelated to the flex pricing feature. Could these be moved to a separate PR to keep this one focused on a single feature?
There was a problem hiding this comment.
These are in fact unrelated. These were causing compile errors for me. These cane be removed or ignored.
| @@ -16,6 +16,11 @@ export const openAiNativeModels = { | |||
| inputPrice: 1.25, | |||
| outputPrice: 10.0, | |||
| cacheReadsPrice: 0.13, | |||
| flexPrice: { | |||
There was a problem hiding this comment.
The flexPrice object is missing cacheWritesPrice. Is this intentional, or should it include all pricing fields for consistency?
There was a problem hiding this comment.
OpenAI does not charged extra for CacheWrite. Check with the pricing of other OpenAI api model pricing, if cache write price is included, then inputPrice can be considered as cachWritesPrice, otherwise if these are not maintained for other openai models, then it can be safely ignored here.
| @@ -1590,7 +1590,7 @@ export class McpHub { | |||
| ) | |||
| } | |||
| if (connection.server.disabled) { | |||
| throw new Error(`Server "${serverName}" is disabled and cannot be used`) | |||
| throw new Error(`Server \"${serverName}\" is disabled and cannot be used`) | |||
There was a problem hiding this comment.
The escaped quotes here are unnecessary since you're using double quotes for the string. This would be cleaner:
Server "" is disabled and cannot be used
Actually, looking at this again, the escaping is correct for the error message. Please disregard this comment.
There was a problem hiding this comment.
Agreed. These should be removed.
hannesrudolph
added
the
Issue/PR - Triage
mechanicmuthu
force-pushed
the
flex-working1
branch
from
738cd69 to
7c16a04
Compare
|
Create a new branch and a fresh clean pull request. CLosing this. Refer to PR 7079. CLosing this. |
Related GitHub Issue
Closes: #
Roo Code Task Context (Optional)
Description
Test Procedure
Pre-Submission Checklist
Screenshots / Videos
Documentation Updates
Additional Notes
Get in Touch
Important
Adds support for flexible pricing tiers in OpenAI cost calculations and updates UI components to handle service tier selection.
calculateApiCostOpenAI()incost.ts.calculateApiCostOpenAI()to useflexPriceifserviceTieris "flex".flexPricetoModelInfoinmodel.tsandproviders/openai.ts.ServiceTiercomponent inServiceTier.tsxto select pricing tier.ApiOptions.tsxandModelInfoView.tsxto display and handle service tier selection.ModelPicker.tsxto integrate service tier selection.calculateApiCostOpenAI()with flex pricing incost.spec.ts.settings.jsonfor service tier descriptions.This description was created by
for 7c16a04. You can customize this summary. It will automatically update as commits are pushed.