Skip to content

Conversation

@cte
Copy link
Collaborator

@cte cte commented Feb 1, 2025

Description

Long lists in the Dropdown have two scrollbars.

Before:

Screenshot_2025-02-01_at_1 06 38_AM

After:

Screenshot 2025-01-31 at 10 35 04 PM

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Checklist:

  • My code follows the patterns of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

Additional context

Related Issues

Reviewers


Important

Fixes double scrollbar issue in dropdowns by removing max-height restriction in .vscrui-checkbox__listbox > ul.

  • CSS Fix:
    • Removes max-height restriction in .vscrui-checkbox__listbox > ul in index.css to prevent double scrollbars in dropdowns.

This description was created by Ellipsis for 03b7763. It will automatically update as commits are pushed.

@changeset-bot
Copy link

changeset-bot bot commented Feb 1, 2025

⚠️ No Changeset found

Latest commit: 03b7763

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Collaborator

@mrubens mrubens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@mrubens mrubens merged commit ce34dcd into main Feb 1, 2025
8 checks passed
@mrubens mrubens deleted the cte/dropdown-fix branch February 1, 2025 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants