Skip to content

Conversation

@daniel-lxs
Copy link
Member

@daniel-lxs daniel-lxs commented Aug 18, 2025

Summary

This PR simplifies the documentation for the ask_followup_question tool to reduce excessive questioning behavior seen with newer models, while keeping the old XML attribute format for backward compatibility.

Changes

Documentation Simplification

  • Reduced documentation size by ~60% (from ~45 lines to ~17 lines)
  • Simplified description: removed verbose explanations about "interactive problem-solving" and "maintaining balance"
  • Streamlined parameter descriptions to be more concise
  • Consolidated from 2 examples to 1 focused example
  • Removed redundant numbered requirements list

Key Points

  • Uses the OLD XML format with mode as an attribute: <suggest mode="code">...
  • ✅ All snapshot tests updated (13 snapshots)
  • ✅ No implementation changes - only documentation
  • ✅ Maintains full backward compatibility
  • ✅ All 3,419 tests passing

Related to PR #6880

This is a companion PR to #6880. The work has been split:

Testing

  • Ran full test suite: all tests passing
  • Updated all affected snapshot tests
  • No functional changes to the tool itself

Impact

This simplified documentation helps prevent newer models from over-using the follow-up question tool while maintaining the exact same functionality for existing implementations.


Important

Simplifies ask_followup_question documentation, reducing verbosity while maintaining backward compatibility and updating snapshot tests.

  • Documentation Simplification:
    • Reduces ask_followup_question documentation from ~45 lines to ~17 lines in ask-followup-question.ts.
    • Simplifies descriptions by removing verbose explanations and redundant lists.
    • Consolidates examples from 2 to 1.
  • Backward Compatibility:
    • Retains old XML format with mode as an attribute.
    • Updates 13 snapshot tests to reflect documentation changes.
  • Testing:
    • All 3,419 tests passing, ensuring no functional changes to the tool.

This description was created by Ellipsis for 6480c50. You can customize this summary. It will automatically update as commits are pushed.

- Reduce documentation from ~45 lines to ~17 lines (~60% reduction)
- Simplify description and parameter explanations
- Consolidate from 2 examples to 1 concise example
- Keep old XML attribute format for backward compatibility
- Update all related snapshot tests

This helps prevent excessive questioning behavior with newer models while
maintaining the same functionality with the existing XML format.
@daniel-lxs daniel-lxs requested review from cte, jr and mrubens as code owners August 18, 2025 15:43
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. documentation Improvements or additions to documentation labels Aug 18, 2025
@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Aug 18, 2025
Copy link
Contributor

@roomote roomote bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this excellent simplification! I've reviewed the changes and the documentation reduction is impressive while maintaining full backward compatibility. The changes are well-tested with all 13 snapshots properly updated. I have a couple of minor suggestions that could further improve clarity, but they're not blockers.

@daniel-lxs daniel-lxs moved this from Triage to Issue [In Progress] in Roo Code Roadmap Aug 18, 2025
@daniel-lxs daniel-lxs moved this from Issue [In Progress] to PR [Needs Review] in Roo Code Roadmap Aug 18, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 18, 2025
@mrubens mrubens merged commit b975ced into main Aug 18, 2025
22 checks passed
@mrubens mrubens deleted the feature/simplify-ask-followup-prompt branch August 18, 2025 16:12
@github-project-automation github-project-automation bot moved this from PR [Needs Review] to Done in Roo Code Roadmap Aug 18, 2025
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Aug 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants