-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Expose thinking tokens for roo/sonic
#7212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution! I've reviewed the changes and found some areas that need attention.
Critical Issue:
- The test file
src/api/providers/__tests__/roo.spec.tsneeds to be updated to include test coverage for the newreasoning_contentfunctionality. This is a significant feature that requires proper testing.
Other feedback provided inline on the changed files.
|
@roomote-agent please fix the failing test |
|
Hi @mrubens! I see the request to fix the failing test. Let me investigate the issue and fix it for you. 🔧 |
The getModel() method in RooHandler was incorrectly using the roo/sonic model info as fallback for unknown models. This fix ensures that unknown models get a proper fallback with supportsPromptCache set to false, which aligns with the test expectations.
|
Hi @mrubens! ✅ I have successfully fixed the failing test. Summary of the fix:The test "should handle unknown model ID with fallback info" in src/api/providers/tests/roo.spec.ts was failing because the RooHandler.getModel() method was incorrectly returning the roo/sonic model info as fallback for unknown models. What I changed:
Test results:✅ platform-unit-test (ubuntu-latest) - Now passing (was failing before) The integration test failure appears to be unrelated to this change and was already failing before my fix. Commit: 7ed6620 |
This reverts commit 7ed6620.
Important
Enhance
RooHandlerto expose reasoning tokens, update model description, and add dynamic provider URL configuration.RooHandlerinroo.tsnow yields reasoning tokens increateMessage().rooModelsinroo.tsto support prompt caching and modifies the model description.ROO_CODE_PROVIDER_URLto.env.samplefor dynamic base URL configuration.createStream()fromcreateMessage()inbase-openai-compatible-provider.tsfor better code organization.roo.spec.tsto test new reasoning token behavior and prompt cache support.This description was created by
for 350bab4. You can customize this summary. It will automatically update as commits are pushed.