Skip to content

Conversation

@mrubens
Copy link
Collaborator

@mrubens mrubens commented Aug 19, 2025

Important

Increase maxTokens for roo/sonic model from 8192 to 16384 in roo.ts and update related tests in roo.spec.ts.

  • Behavior:
    • Increase maxTokens for roo/sonic model from 8192 to 16384 in roo.ts and roo.spec.ts.
  • Tests:
    • Update test in roo.spec.ts to expect maxTokens of 16384 for unknown models.
  • Model Configuration:
    • Update maxTokens in roo.ts to 16384 for roo/sonic model.

This description was created by Ellipsis for f64124c. You can customize this summary. It will automatically update as commits are pushed.

@mrubens mrubens requested review from cte and jr as code owners August 19, 2025 14:15
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Aug 19, 2025
@mrubens mrubens merged commit ede26b8 into main Aug 19, 2025
15 checks passed
@mrubens mrubens deleted the increase_sonic_max_tokens branch August 19, 2025 14:19
@github-project-automation github-project-automation bot moved this from Triage to Done in Roo Code Roadmap Aug 19, 2025
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Aug 19, 2025
Copy link
Contributor

@roomote roomote bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! This is a clean and focused PR that successfully increases the max_tokens limit for the roo/sonic model from 8192 to 16384.

The changes are consistent across all three affected files:

  • ✅ Model configuration updated
  • ✅ Fallback model info updated
  • ✅ Test expectations updated

Good use of numeric separators for readability. LGTM! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants