-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Release v3.25.18 #7219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v3.25.18 #7219
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for preparing this release! I've reviewed the changeset and have some suggestions to improve consistency and traceability in the changelog.
| "roo-cline": patch | ||
| --- | ||
|
|
||
| - Fix: respect enableReasoningEffort setting when determining reasoning usage (#7048 by @ikbencasdoei, PR by @app/roomote) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed the attribution format varies between entries. Lines 5-6 use "by @username, PR by @username" while lines 7-8 use "thanks @username!". Would it be better to standardize on one format for consistency?
|
|
||
| - Fix: respect enableReasoningEffort setting when determining reasoning usage (#7048 by @ikbencasdoei, PR by @app/roomote) | ||
| - Fix: prevent duplicate LM Studio models with case-insensitive deduplication (#6954 by @fbuechler, PR by @daniel-lxs) | ||
| - Add support for Sonic model (thanks @mrubens!) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we include the PR number here for better traceability? Something like "Add support for Sonic model (#XXXX, thanks @mrubens!)" would make it easier to find the original implementation.
| - Fix: respect enableReasoningEffort setting when determining reasoning usage (#7048 by @ikbencasdoei, PR by @app/roomote) | ||
| - Fix: prevent duplicate LM Studio models with case-insensitive deduplication (#6954 by @fbuechler, PR by @daniel-lxs) | ||
| - Add support for Sonic model (thanks @mrubens!) | ||
| - Feat: simplify ask_followup_question prompt documentation (thanks @daniel-lxs!) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For consistency with the other entries, should this use "Feat:" or should line 7 use "Add:"? Having consistent prefixes (Fix:, Feat:, Add:) would improve readability.
Release preparation for v3.25.18. This PR includes the changeset and any necessary documentation updates.
Important
Release v3.25.18 with bug fixes, Sonic model support, and documentation updates.
enableReasoningEffortsetting for reasoning usage.ask_followup_questionprompt documentation.This description was created by
for 60bb694. You can customize this summary. It will automatically update as commits are pushed.