-
Notifications
You must be signed in to change notification settings - Fork 2.6k
chore: add changeset for v3.25.18 #7223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
f330bbf to
4d731bc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution! I've reviewed the changeset and have some suggestions for improvement to enhance consistency and traceability.
| "roo-cline": patch | ||
| --- | ||
|
|
||
| - Fix: respect enableReasoningEffort setting when determining reasoning usage (#7048 by @ikbencasdoei, PR by @app/roomote) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed the attribution format varies between entries. The first two use "by @username, PR by @app/roomote" while the last three use "thanks @username!". Would it be better to standardize this for consistency?
For example, all entries could follow either:
- "Fix: description (#issue by @reporter, PR by @Implementer)"
- "Fix: description (thanks @contributor!)"
What do you think?
|
|
||
| - Fix: respect enableReasoningEffort setting when determining reasoning usage (#7048 by @ikbencasdoei, PR by @app/roomote) | ||
| - Fix: prevent duplicate LM Studio models with case-insensitive deduplication (#6954 by @fbuechler, PR by @daniel-lxs) | ||
| - Add support for Sonic model (thanks @mrubens!) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These feature entries don't include issue or PR references like the fixes above do. Including references (if they exist) would help with traceability. For instance:
- Add support for Sonic model (#XXXX, thanks @mrubens!)
- Feat: simplify ask_followup_question prompt documentation (#XXXX, thanks @daniel-lxs!)
- Feat: simple read_file tool for single-file-only models (#XXXX, thanks @daniel-lxs!)
| - Fix: prevent duplicate LM Studio models with case-insensitive deduplication (#6954 by @fbuechler, PR by @daniel-lxs) | ||
| - Add support for Sonic model (thanks @mrubens!) | ||
| - Feat: simplify ask_followup_question prompt documentation (thanks @daniel-lxs!) | ||
| - Feat: simple read_file tool for single-file-only models (thanks @daniel-lxs!) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider adding more context to this feature description? For example, what specific use case does this enable or what problem does it solve for single-file-only models? This would help users understand the value of this addition.
Important
Add changeset for v3.25.18 with fixes for reasoning usage and model deduplication, and new features including Sonic model support.
enableReasoningEffortsetting for reasoning usage.ask_followup_questionprompt documentation.read_filetool for single-file-only models.This description was created by
for 4d731bc. You can customize this summary. It will automatically update as commits are pushed.