-
Notifications
You must be signed in to change notification settings - Fork 2.6k
feat: auto-exclude large non-code files from checkpoints #7228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
24d887b
feat(checkpoints): auto-exclude large non-code files from checkpoints…
roomote 038d0d2
feat: optimize large file scanning by pre-filtering git-lfs patterns
roomote 8ca0c46
checkpoints: make large-file threshold configurable via ROO_CHECKPOIN…
hannesrudolph 7280966
fix(checkpoints): correct Windows Thumbs cache pattern (Thumbs.db) an…
hannesrudolph 18f76b8
fix: only generate exclude file once on initial creation
a52dad9
fix: ensure exclude file is properly created on initial shadow repo s…
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -11,7 +11,7 @@ import { fileExistsAtPath } from "../../utils/fs" | |||||
| import { executeRipgrep } from "../../services/search/file-search" | ||||||
|
|
||||||
| import { CheckpointDiff, CheckpointResult, CheckpointEventMap } from "./types" | ||||||
| import { getExcludePatterns } from "./excludes" | ||||||
| import { getExcludePatterns, getExcludePatternsWithStats } from "./excludes" | ||||||
|
|
||||||
| export abstract class ShadowCheckpointService extends EventEmitter { | ||||||
| public readonly taskId: string | ||||||
|
|
@@ -139,8 +139,15 @@ export abstract class ShadowCheckpointService extends EventEmitter { | |||||
| // .gitignore. | ||||||
| protected async writeExcludeFile() { | ||||||
| await fs.mkdir(path.join(this.dotGitDir, "info"), { recursive: true }) | ||||||
| const patterns = await getExcludePatterns(this.workspaceDir) | ||||||
| const { patterns, stats } = await getExcludePatternsWithStats(this.workspaceDir) | ||||||
| await fs.writeFile(path.join(this.dotGitDir, "info", "exclude"), patterns.join("\n")) | ||||||
|
|
||||||
| if (stats?.largeFilesExcluded && stats.largeFilesExcluded > 0) { | ||||||
|
||||||
| if (stats?.largeFilesExcluded && stats.largeFilesExcluded > 0) { | |
| if (stats.largeFilesExcluded > 0) { |
hannesrudolph marked this conversation as resolved.
Show resolved
Hide resolved
hannesrudolph marked this conversation as resolved.
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.