Skip to content

Conversation

@mrubens
Copy link
Collaborator

@mrubens mrubens commented Aug 19, 2025

Important

Add missing API keys to SECRET_STATE_KEYS and update models and configurations for vscode-lm.

  • Configuration:
    • Add missing zaiApiKey and doubaoApiKey to SECRET_STATE_KEYS.
  • Models:
    • Add new models and update configurations for vscode-lm.

This description was created by Ellipsis for 96228f0. You can customize this summary. It will automatically update as commits are pushed.

@mrubens mrubens requested review from cte and jr as code owners August 19, 2025 21:00
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Aug 19, 2025
@mrubens mrubens merged commit 613abe0 into main Aug 19, 2025
14 checks passed
@mrubens mrubens deleted the v3.25.18.3 branch August 19, 2025 21:00
@github-project-automation github-project-automation bot moved this from Triage to Done in Roo Code Roadmap Aug 19, 2025
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Aug 19, 2025
Copy link
Contributor

@roomote roomote bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for documenting these changes! I've reviewed the changeset file and have a few suggestions that might help improve clarity for future reference.

"roo-cline": patch
---

- Fix: Add missing zaiApiKey and doubaoApiKey to SECRET_STATE_KEYS (#7082 by @app/roomote)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this attribution pattern intentional? The fix references issue #7082 which was created by @jayxuz, but credits @app/roomote. Would it be clearer to separate issue reporter from PR author attribution, something like: "(#7082 reported by @jayxuz, fixed by @app/roomote)"?

"roo-cline": patch
---

- Fix: Add missing zaiApiKey and doubaoApiKey to SECRET_STATE_KEYS (#7082 by @app/roomote)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I notice this changeset only documents the changes but doesn't include the actual implementation. Were the code changes for adding zaiApiKey and doubaoApiKey to SECRET_STATE_KEYS already merged in a different PR? It might be helpful to reference that PR number here for easier tracking.

---

- Fix: Add missing zaiApiKey and doubaoApiKey to SECRET_STATE_KEYS (#7082 by @app/roomote)
- Feat: Add new models and update configurations for vscode-lm (thanks @NaccOll!)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we be more specific about which models were added and what configurations were updated? This level of detail would be helpful for debugging or if we need to rollback specific changes in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog-ready size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants