-
Notifications
You must be signed in to change notification settings - Fork 2.6k
More changes #7232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More changes #7232
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for documenting these changes! I've reviewed the changeset file and have a few suggestions that might help improve clarity for future reference.
| "roo-cline": patch | ||
| --- | ||
|
|
||
| - Fix: Add missing zaiApiKey and doubaoApiKey to SECRET_STATE_KEYS (#7082 by @app/roomote) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "roo-cline": patch | ||
| --- | ||
|
|
||
| - Fix: Add missing zaiApiKey and doubaoApiKey to SECRET_STATE_KEYS (#7082 by @app/roomote) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I notice this changeset only documents the changes but doesn't include the actual implementation. Were the code changes for adding zaiApiKey and doubaoApiKey to SECRET_STATE_KEYS already merged in a different PR? It might be helpful to reference that PR number here for easier tracking.
| --- | ||
|
|
||
| - Fix: Add missing zaiApiKey and doubaoApiKey to SECRET_STATE_KEYS (#7082 by @app/roomote) | ||
| - Feat: Add new models and update configurations for vscode-lm (thanks @NaccOll!) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we be more specific about which models were added and what configurations were updated? This level of detail would be helpful for debugging or if we need to rollback specific changes in the future.
Important
Add missing API keys to
SECRET_STATE_KEYSand update models and configurations forvscode-lm.zaiApiKeyanddoubaoApiKeytoSECRET_STATE_KEYS.vscode-lm.This description was created by
for 96228f0. You can customize this summary. It will automatically update as commits are pushed.