Skip to content

Conversation

@requesty-JohnCosta27
Copy link
Contributor

@requesty-JohnCosta27 requesty-JohnCosta27 commented Aug 21, 2025

Closes: #7274

Description

Replace every URL where Requesty is used and use the base URL the user provided. This is mostly for models and API keys.

Test Procedure

  1. Open Roo-Code and set Requesty as a provider
  2. Set a Requesty base URL
  3. Click "Get Requesty API key" and check it redirected you to the base URL.

Pre-Submission Checklist

  • Issue Linked: This PR is linked to an approved GitHub Issue (see "Related GitHub Issue" above).
  • Scope: My changes are focused on the linked issue (one major feature/fix per PR).
  • Self-Review: I have performed a thorough self-review of my code.
  • Testing: New and/or updated tests have been added to cover my changes (if applicable).
  • Documentation Impact: I have considered if my changes require documentation updates (see "Documentation Updates" section below).
  • Contribution Guidelines: I have read and agree to the Contributor Guidelines.

Screenshots / Videos

Documentation Updates

Additional Notes

Get in Touch


Important

This PR standardizes the use of a base URL for Requesty across API requests and UI components, ensuring consistent URL handling in the application.

  • Behavior:
    • Use baseUrl for Requesty API requests in getRequestyModels() in requesty.ts and getRequestyKeyInfo() in useRequestyKeyInfo.ts.
    • Update RequestyHandler in requesty.ts to use baseUrl for initializing OpenAI client.
    • Modify webviewMessageHandler to include baseUrl in GetModelsOptions for Requesty.
  • UI Components:
    • Add baseUrl handling in Requesty component in Requesty.tsx for API key and model selection.
    • Update RequestyBalanceDisplay in RequestyBalanceDisplay.tsx to use baseUrl for balance URL.
  • Utilities:
    • Introduce toRequestyServiceUrl() in requesty.ts to resolve service URLs based on baseUrl.

This description was created by Ellipsis for f0a5bd6. You can customize this summary. It will automatically update as commits are pushed.

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. enhancement New feature or request labels Aug 21, 2025
Copy link
Contributor

@roomote roomote bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! I've reviewed the changes and found several issues that need attention. The implementation successfully addresses the core issue of using the base URL across all Requesty requests, but there are some concerns about robustness and test coverage.

Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>
@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Aug 21, 2025
@daniel-lxs daniel-lxs moved this from Triage to PR [Needs Prelim Review] in Roo Code Roadmap Aug 21, 2025
@hannesrudolph hannesrudolph added PR - Needs Preliminary Review and removed Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. labels Aug 21, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 22, 2025
@mrubens
Copy link
Collaborator

mrubens commented Aug 22, 2025

@roomote-agent can you fix the failing test?

@roomote
Copy link
Contributor

roomote bot commented Aug 22, 2025

Hi @mrubens! I'm looking into the failing test now. I'll investigate the issue and push a fix shortly.

@roomote
Copy link
Contributor

roomote bot commented Aug 22, 2025

Hi @mrubens! I've fixed the failing tests. The issue was that the tests needed to be updated after the changes to support custom base URLs for Requesty.

What was fixed:

  1. requesty.spec.ts: Updated the test to use a valid URL format (https://custom.requesty.ai/v1) instead of some-base-url
  2. modelCache.spec.ts: Updated the test expectation to match the new parameter order in getRequestyModels (baseUrl is now the first parameter, apiKey is second)

I've created PR #7336 with these test fixes since I couldn't push directly to this PR's branch. The tests are now passing locally. You can either merge #7336 first or cherry-pick the commit 64ac30d0a into this PR.

Let me know if you need anything else!

@daniel-lxs
Copy link
Member

Superseded by #7337

@daniel-lxs daniel-lxs closed this Aug 22, 2025
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Aug 22, 2025
@github-project-automation github-project-automation bot moved this from PR [Needs Prelim Review] to Done in Roo Code Roadmap Aug 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request lgtm This PR has been approved by a maintainer PR - Needs Preliminary Review size:L This PR changes 100-499 lines, ignoring generated files.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Requesty's base URL is not used for all requests

5 participants