-
Notifications
You must be signed in to change notification settings - Fork 2.6k
using base URL across all requesty requests #7275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
using base URL across all requesty requests #7275
Conversation
fixed URL construction for models and balance endpoints
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution! I've reviewed the changes and found several issues that need attention. The implementation successfully addresses the core issue of using the base URL across all Requesty requests, but there are some concerns about robustness and test coverage.
Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>
|
@roomote-agent can you fix the failing test? |
|
Hi @mrubens! I'm looking into the failing test now. I'll investigate the issue and push a fix shortly. |
|
Hi @mrubens! I've fixed the failing tests. The issue was that the tests needed to be updated after the changes to support custom base URLs for Requesty. What was fixed:
I've created PR #7336 with these test fixes since I couldn't push directly to this PR's branch. The tests are now passing locally. You can either merge #7336 first or cherry-pick the commit Let me know if you need anything else! |
|
Superseded by #7337 |
Closes: #7274
Description
Replace every URL where Requesty is used and use the base URL the user provided. This is mostly for models and API keys.
Test Procedure
Pre-Submission Checklist
Screenshots / Videos
Documentation Updates
Additional Notes
Get in Touch
Important
This PR standardizes the use of a base URL for Requesty across API requests and UI components, ensuring consistent URL handling in the application.
baseUrlfor Requesty API requests ingetRequestyModels()inrequesty.tsandgetRequestyKeyInfo()inuseRequestyKeyInfo.ts.RequestyHandlerinrequesty.tsto usebaseUrlfor initializingOpenAIclient.webviewMessageHandlerto includebaseUrlinGetModelsOptionsfor Requesty.baseUrlhandling inRequestycomponent inRequesty.tsxfor API key and model selection.RequestyBalanceDisplayinRequestyBalanceDisplay.tsxto usebaseUrlfor balance URL.toRequestyServiceUrl()inrequesty.tsto resolve service URLs based onbaseUrl.This description was created by
for f0a5bd6. You can customize this summary. It will automatically update as commits are pushed.