fix: respect UI-configured dimension settings for file index #7281
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes issue #5754 where RooCode was ignoring the dimension settings configured in the UI for file indexing.
Problem
When users configured a specific dimension value (e.g., 1536) in the UI settings, RooCode was still using 1024 dimensions, causing a "Vector dimension error: expected dim: 1536, got 1024" error. This was due to a hardcoded fallback value that was overriding the user's configuration.
Solution
Removed the hardcoded fallback value (
?? 1536) fromcodebaseIndexEmbedderModelDimensioninClineProvider.ts. This allows the proper dimension resolution hierarchy to work:Changes
src/core/webview/ClineProvider.tsline 1870undefinedif not setTesting
Impact
This fix ensures that:
Fixes #5754
cc @jhstatewide @rstanislav
Important
Fixes dimension mismatch in
ClineProvider.tsby removing hardcoded fallback, ensuring user-configured dimensions are respected.codebaseIndexEmbedderModelDimensioninClineProvider.ts.This description was created by
for d774e6a. You can customize this summary. It will automatically update as commits are pushed.