Skip to content

Conversation

@elianiva
Copy link
Contributor

@elianiva elianiva commented Aug 22, 2025

Related GitHub Issue

Closes: #3909

Roo Code Task Context (Optional)

Description

Changed the auto approve menu toggle to stay at the bottom, this provides better UX since the trigger stays. It's also consistent with the behaviour of the top bar where the trigger stays at the top. It reduces mouse movements needed.

Test Procedure

Manual testing

Pre-Submission Checklist

  • Issue Linked: This PR is linked to an approved GitHub Issue (see "Related GitHub Issue" above).
  • Scope: My changes are focused on the linked issue (one major feature/fix per PR).
  • Self-Review: I have performed a thorough self-review of my code.
  • Testing: New and/or updated tests have been added to cover my changes (if applicable).
  • Documentation Impact: I have considered if my changes require documentation updates (see "Documentation Updates" section below).
  • Contribution Guidelines: I have read and agree to the Contributor Guidelines.

Screenshots / Videos

Screen.Recording.2025-08-22.at.20.15.20.mov

Documentation Updates

Additional Notes

Get in Touch

@elianiva


Important

Fixes AutoApproveMenu to keep the toggle at the bottom when expanded, improving UX by reducing mouse movement.

  • UI Behavior:
    • In AutoApproveMenu, when isExpanded is true, the toggle section is now rendered at the bottom of the component.
    • Adjusts padding and chevron icon direction to reflect the new toggle position.
  • Code Changes:
    • Moves the expanded content block to render before the toggle trigger in AutoApproveMenu.tsx.
    • Updates chevron icon class to codicon-chevron-up when expanded.

This description was created by Ellipsis for 156cbe7. You can customize this summary. It will automatically update as commits are pushed.

@elianiva elianiva requested review from cte, jr and mrubens as code owners August 22, 2025 13:27
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. UI/UX UI/UX related or focused labels Aug 22, 2025
Copy link
Contributor

@roomote roomote bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! This is a nice UX improvement that addresses the issue well. The implementation is clean and focused. I've left a couple of minor suggestions inline for your consideration.

@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Aug 22, 2025
Copy link
Member

@daniel-lxs daniel-lxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @elianiva this looks a lot better!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 23, 2025
- Replace inline styles with Tailwind CSS classes for better maintainability
- Add smooth 200ms transition when expanding/collapsing
- Chevron rotates from right (→) to up (↑) matching the content position above
- Consistent with other components like ApiConfigSelector
@daniel-lxs daniel-lxs moved this from Triage to PR [Needs Review] in Roo Code Roadmap Aug 23, 2025
@cte cte merged commit fc70012 into RooCodeInc:main Aug 23, 2025
10 checks passed
@github-project-automation github-project-automation bot moved this from PR [Needs Review] to Done in Roo Code Roadmap Aug 23, 2025
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Aug 23, 2025
@elianiva elianiva deleted the fix/auto-approve-ux branch August 23, 2025 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files. UI/UX UI/UX related or focused

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Auto Approve Menu Toggleability

4 participants