-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Deselect unwanted modes including Built-in ones (by copying to custom_modes.yaml, save disabled state in file #7347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deselect unwanted modes including Built-in ones (by copying to custom_modes.yaml, save disabled state in file #7347
Conversation
…ModeEnableDisableDialog
…onality in ModeManager and ModeEnableDisableDialog
…tor toggle functions in ModeEnableDisableDialog
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution! I've reviewed the changes for enabling/disabling modes functionality.
Review Summary
This PR adds valuable functionality for enabling/disabling modes, including built-in ones. However, there are several issues that need attention:
Critical Issues (Must Fix):
-
Typos in documentation:
- PR description has typos: "correcponding" should be "corresponding", "versible" should be "visible"
- README.md line ~394: "custom_model.yaml" should be "custom_modes.yaml"
-
Incomplete code: The console.warn message at line ~1095 in CustomModesManager.ts appears to be cut off mid-sentence
Important Suggestions:
-
Documentation placement: The PR adds 91 lines to README.md. Consider moving detailed documentation to a dedicated docs page and keeping only a summary with link in README
-
Error handling: The setMultipleModesDisabled method silently continues when modes aren't found. Consider collecting and reporting all failed updates
-
UI consistency: The confirmation dialog in ModeEnableDisableDialog.tsx uses inline styles instead of the established theming system
Minor Improvements:
- Logging: Line 492 in CustomModesManager.ts uses console.info - consider using the existing logger utility
- Code organization: The setMultipleModesDisabled method is 90+ lines - consider extracting helper methods
- Test coverage: Consider adding more comprehensive tests for bulk update functionality
Overall, this is a useful feature that will help users manage modes more effectively. Please address the critical issues before merging.
…xt for custom modes
…EnableDisableDialog
2c7ca10 to
c789545
Compare
Related GitHub Issue #3236 #3714 #3007 #2492 #2935
In these Issues / Feature requests, the issue could be resolved by disabling Built-in modes and disabling cutom modes in a versible fashion.
Roo Code Task Context (Optional)
Description
Ability to enable / disable modes with correcponding system prompt changes, validation in new task tool, and error messages with hints in switch mode tool.
Test Procedure
Some test added.
Pre-Submission Checklist
Done
Screenshots / Videos
Built in mode is converted to GLobal mode if disabled.

On deletion of the Global Mode, the In built mode is restored (no longer over-ridden.
Documentation Updates
Additional Notes
Added optional :
disabled: true to the .roomodes and custom_modes.yaml file format.
Get in Touch