Skip to content

Conversation

@mechanicmuthu
Copy link

Related GitHub Issue #3236 #3714 #3007 #2492 #2935

In these Issues / Feature requests, the issue could be resolved by disabling Built-in modes and disabling cutom modes in a versible fashion.

Roo Code Task Context (Optional)

Description

Ability to enable / disable modes with correcponding system prompt changes, validation in new task tool, and error messages with hints in switch mode tool.

Test Procedure

Some test added.

Pre-Submission Checklist

Done

Screenshots / Videos

Screenshot 2025-08-23 at 12 55 51 PM

Built in mode is converted to GLobal mode if disabled.
On deletion of the Global Mode, the In built mode is restored (no longer over-ridden.
Screenshot 2025-08-23 at 12 56 21 PM

Documentation Updates

Additional Notes

Added optional :
disabled: true to the .roomodes and custom_modes.yaml file format.

Get in Touch

Copy link
Contributor

@roomote roomote bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! I've reviewed the changes for enabling/disabling modes functionality.

Review Summary

This PR adds valuable functionality for enabling/disabling modes, including built-in ones. However, there are several issues that need attention:

Critical Issues (Must Fix):

  1. Typos in documentation:

    • PR description has typos: "correcponding" should be "corresponding", "versible" should be "visible"
    • README.md line ~394: "custom_model.yaml" should be "custom_modes.yaml"
  2. Incomplete code: The console.warn message at line ~1095 in CustomModesManager.ts appears to be cut off mid-sentence

Important Suggestions:

  1. Documentation placement: The PR adds 91 lines to README.md. Consider moving detailed documentation to a dedicated docs page and keeping only a summary with link in README

  2. Error handling: The setMultipleModesDisabled method silently continues when modes aren't found. Consider collecting and reporting all failed updates

  3. UI consistency: The confirmation dialog in ModeEnableDisableDialog.tsx uses inline styles instead of the established theming system

Minor Improvements:

  1. Logging: Line 492 in CustomModesManager.ts uses console.info - consider using the existing logger utility
  2. Code organization: The setMultipleModesDisabled method is 90+ lines - consider extracting helper methods
  3. Test coverage: Consider adding more comprehensive tests for bulk update functionality

Overall, this is a useful feature that will help users manage modes more effectively. Please address the critical issues before merging.

@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Aug 23, 2025
@daniel-lxs daniel-lxs moved this from Triage to PR [Draft / In Progress] in Roo Code Roadmap Aug 23, 2025
@hannesrudolph hannesrudolph added PR - Draft / In Progress and removed Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. labels Aug 23, 2025
@mechanicmuthu mechanicmuthu force-pushed the deselect-unwanted-modes branch from 2c7ca10 to c789545 Compare August 27, 2025 15:45
@github-project-automation github-project-automation bot moved this from PR [Draft / In Progress] to Done in Roo Code Roadmap Sep 23, 2025
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Sep 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants