-
Notifications
You must be signed in to change notification settings - Fork 2.6k
feat: add qwen-code provider support with complete translations #7364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| import type { ModelInfo } from "../model.js" | ||
| import type { ProviderName } from "../provider-settings.js" | ||
|
|
||
| export const qwenCodeModels = { | ||
| "qwen3-coder-plus": { | ||
| id: "qwen3-coder-plus", | ||
| name: "Qwen3 Coder Plus", | ||
| provider: "qwen-code" as ProviderName, | ||
| contextWindow: 1000000, | ||
| maxTokens: 65536, | ||
| supportsPromptCache: false, | ||
| }, | ||
| "qwen3-coder-flash": { | ||
| id: "qwen3-coder-flash", | ||
| name: "Qwen3 Coder Flash", | ||
| provider: "qwen-code" as ProviderName, | ||
| contextWindow: 1000000, | ||
| maxTokens: 65536, | ||
| supportsPromptCache: false, | ||
| }, | ||
| } as const | ||
|
|
||
| export type QwenCodeModelId = keyof typeof qwenCodeModels | ||
|
|
||
| export const qwenCodeDefaultModelId: QwenCodeModelId = "qwen3-coder-plus" | ||
|
|
||
| export const isQwenCodeModel = (modelId: string): modelId is QwenCodeModelId => { | ||
| return modelId in qwenCodeModels | ||
| } | ||
|
|
||
| export const getQwenCodeModelInfo = (modelId: string): ModelInfo => { | ||
| if (isQwenCodeModel(modelId)) { | ||
| return qwenCodeModels[modelId] | ||
| } | ||
| // Fallback to a default or throw an error | ||
| return qwenCodeModels[qwenCodeDefaultModelId] | ||
| } | ||
|
|
||
| export type QwenCodeProvider = { | ||
| id: "qwen-code" | ||
| apiKey?: string | ||
| baseUrl?: string | ||
| model: QwenCodeModelId | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,54 @@ | ||
| import { describe, it, expect, vi } from "vitest" | ||
| import { QwenCodeHandler } from "../qwen-code" | ||
| import { ApiHandlerOptions } from "../../../shared/api" | ||
|
|
||
| // Mock fs | ||
| vi.mock("fs", () => ({ | ||
| existsSync: vi.fn(), | ||
| readFileSync: vi.fn(), | ||
| })) | ||
|
|
||
| // Mock os | ||
| vi.mock("os", () => ({ | ||
| homedir: () => "/home/user", | ||
| })) | ||
|
|
||
| // Mock path | ||
| vi.mock("path", () => ({ | ||
| resolve: vi.fn((...args) => args.join("/")), | ||
| join: vi.fn((...args) => args.join("/")), | ||
| })) | ||
|
|
||
| describe("QwenCodeHandler", () => { | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The test coverage seems insufficient. Consider adding tests for:
Would you like me to suggest some additional test cases? |
||
| it("should initialize with correct model configuration", () => { | ||
| const options: ApiHandlerOptions = { | ||
| apiModelId: "qwen3-coder-plus", | ||
| } | ||
| const handler = new QwenCodeHandler(options) | ||
|
|
||
| const model = handler.getModel() | ||
| expect(model.id).toBe("qwen3-coder-plus") | ||
| expect(model.info).toBeDefined() | ||
| expect(model.info?.supportsPromptCache).toBe(false) | ||
| }) | ||
|
|
||
| it("should use default model when none specified", () => { | ||
| const options: ApiHandlerOptions = {} | ||
| const handler = new QwenCodeHandler(options) | ||
|
|
||
| const model = handler.getModel() | ||
| expect(model.id).toBe("qwen3-coder-plus") // default model | ||
| expect(model.info).toBeDefined() | ||
| }) | ||
|
|
||
| it("should use custom oauth path when provided", () => { | ||
| const customPath = "/custom/path/oauth.json" | ||
| const options: ApiHandlerOptions = { | ||
| qwenCodeOAuthPath: customPath, | ||
| } | ||
| const handler = new QwenCodeHandler(options) | ||
|
|
||
| // Handler should initialize without throwing | ||
| expect(handler).toBeDefined() | ||
| }) | ||
| }) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
QwenCodeProvidertype includesapiKeyandbaseUrlfields, but this is an OAuth-based provider that doesn't use API keys. Should these fields be removed to avoid confusion?