-
Notifications
You must be signed in to change notification settings - Fork 2.6k
fix: display current LLM model in task header UI #7439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Added model display in both collapsed and expanded task header views - Shows model name next to token count in collapsed view - Added dedicated Model row in expanded task details table - Added localization support for "Model" label in chat.json Fixes #7438
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewing my own code is like debugging in a mirror - everything looks backwards and I still missed half the bugs.
| "collapse": "Collapse task", | ||
| "seeMore": "See more", | ||
| "seeLess": "See less", | ||
| "model": "Model", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This only adds the translation to the English locale. What about our non-English speaking users? All other language files (es, fr, de, ja, ko, zh-CN, etc.) need this "model" key added too, or they'll see missing translation warnings.
You'll need to add the "model" key to all locale files in webview-ui/src/i18n/locales/*/chat.json
| const reservedForOutput = maxTokens || 0 | ||
| const availableSpace = contextWindow - (contextTokens || 0) - reservedForOutput | ||
| {/* Model display */} | ||
| {modelId && <span className="text-vscode-descriptionForeground opacity-80">{modelId}</span>} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The opacity-80 styling might make the model name less visible, which contradicts the goal of addressing the visibility issue from #7438. Since this is meant to fix a critical UX problem about not being able to see the model, should we make it more prominent?
| {t("chat:task.model")} | ||
| </th> | ||
| <td className="align-top"> | ||
| <span>{modelId}</span> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Model IDs can be quite long (e.g., "anthropic/claude-3-opus-20240229"). Consider adding a tooltip with the full model name or truncating with ellipsis for better UX when space is limited in the collapsed view.
This PR attempts to address Issue #7438 by adding visibility of the current LLM model in the task header interface.
Problem
Users were unable to see which LLM model they were using in the interface, as reported in the critical UX feedback.
Solution
Added model display in the TaskHeader component:
Changes
webview-ui/src/components/chat/TaskHeader.tsxto display the model ID in both collapsed and expanded stateswebview-ui/src/i18n/locales/en/chat.jsonTesting
Future Improvements
Fixes #7438
Feedback and guidance are welcome!
Important
Display current LLM model in
TaskHeaderUI, with localization support, addressing UX feedback.TaskHeader.tsx: Display current LLM model ID next to token count in collapsed view and in a dedicated row in expanded view.chat.jsonfor localization support.This description was created by
for 30f792d. You can customize this summary. It will automatically update as commits are pushed.