fix: improve Azure OpenAI detection and update API version for o3 models #7499

roomote · 2025-08-28T17:20:17Z

Summary

This PR attempts to address Issue #7498 where Azure OpenAI returns 404 errors when using newer models like o3-mini through the OpenAI Compatible provider.

Problem

Users were experiencing 404 errors when trying to use Azure OpenAI with newer models (like o3-mini) through Roo-Code's OpenAI Compatible provider, even though the same configuration worked in Python code using the Azure OpenAI SDK.

Root Cause

The default Azure API version was outdated (2024-08-01-preview) and didn't support newer models
Azure OpenAI detection logic wasn't comprehensive enough to catch all Azure endpoint URL patterns

Solution

1. Updated Azure API Version

Changed default from 2024-08-01-preview to 2025-03-01-preview
This matches the version used in the user's working Python example

2. Enhanced Azure Detection Logic

Added new _isAzureOpenAi() method with improved URL pattern detection
Now properly detects:
- .openai.azure.com domains
- URLs containing /openai/deployments/ paths
- Explicit openAiUseAzure flag

3. Added Comprehensive Tests

Added 4 new test cases for Azure OpenAI detection scenarios
Fixed test mocks to properly support AzureOpenAI client
All tests passing (50 tests total)

Testing

✅ All existing tests pass
✅ New tests added for Azure detection scenarios
✅ Linting and type checking pass
✅ Code review confidence: 95%

Related Issues

Fixes #7498

Feedback and guidance are welcome!

Important

Updated Azure OpenAI API version and detection logic to support newer models and added comprehensive tests.

Behavior:
- Updated Azure API version from 2024-08-01-preview to 2025-03-01-preview in openai.ts to support newer models like o3-mini.
- Improved Azure OpenAI detection logic in OpenAiHandler by adding _isAzureOpenAi() method to detect .openai.azure.com domains, URLs with /openai/deployments/, and openAiUseAzure flag.
Testing:
- Added 4 new test cases in openai.spec.ts for Azure OpenAI detection scenarios.
- Updated test mocks to support AzureOpenAI client.
- All tests passing (50 tests total).

^{This description was created by}^{for 4f7a858. You can customize this summary. It will automatically update as commits are pushed.}

- Updated default Azure API version from 2024-08-01-preview to 2025-03-01-preview to support newer models like o3-mini - Enhanced Azure OpenAI detection logic to check for .openai.azure.com domains and /openai/deployments/ paths - Added comprehensive tests for Azure OpenAI detection scenarios - Fixed test mocks to properly support AzureOpenAI client Fixes #7498

ellipsis-dev · 2025-08-28T17:22:10Z

src/api/providers/__tests__/openai.spec.ts

 		})
 	})
+
+	describe("Azure OpenAI Detection", () => {


The new Azure OpenAI detection tests are a great addition. For even stronger validation, consider asserting that the underlying client is an instance of AzureOpenAI (or that the 'apiVersion' parameter is set to the updated value) when an Azure endpoint is detected rather than only checking the handler instance.

roomote

Reviewing my own code is like debugging in production - technically possible but morally questionable.

roomote · 2025-08-28T17:25:10Z

src/api/providers/openai.ts

+			urlHost.endsWith(".azure.com") ||
+			urlHost.endsWith(".openai.azure.com") ||
+			// Check if URL contains Azure OpenAI specific paths
+			baseUrl.includes("/openai/deployments/")


The URL pattern check for /openai/deployments/ could potentially match non-Azure URLs. Is this intentional, or should we make the detection more specific to avoid false positives?

For example, a custom OpenAI-compatible API at https://custom-api.com/openai/deployments/model would be incorrectly detected as Azure.

roomote · 2025-08-28T17:25:10Z

src/api/providers/openai.ts

 		return urlHost.endsWith(".services.ai.azure.com")
 	}

+	private _isAzureOpenAi(baseUrl?: string): boolean {


Consider adding JSDoc comments to document this method's purpose and the URL patterns it detects:

Suggested change

private _isAzureOpenAi(baseUrl?: string): boolean {

/**

* Detects if the provided base URL is an Azure OpenAI endpoint

* @param baseUrl - The API base URL to check

* @returns true if the URL matches Azure OpenAI patterns:

* - Domains ending with .openai.azure.com

* - URLs containing /openai/deployments/ path

* - Domains ending with .azure.com

*/

private _isAzureOpenAi(baseUrl?: string): boolean {

roomote · 2025-08-28T17:25:11Z

packages/types/src/providers/openai.ts

 // https://learn.microsoft.com/en-us/azure/ai-services/openai/api-version-deprecation
 // https://learn.microsoft.com/en-us/azure/ai-services/openai/reference#api-specs
-export const azureOpenAiDefaultApiVersion = "2024-08-01-preview"
+// Updated to support newer models like o3-mini


Could we expand this comment to explain why 2025-03-01-preview specifically enables o3 model support? This would help future maintainers understand when to update the API version.

roomote · 2025-08-28T17:25:11Z

src/api/providers/__tests__/openai.spec.ts

+			})
+			expect(azureHandler).toBeInstanceOf(OpenAiHandler)
+			// The handler should use the updated API version (2025-03-01-preview)
+		})


Consider adding a test case for the potential edge case where a non-Azure URL contains /openai/deployments/. This would help ensure the detection logic handles all scenarios correctly:

Suggested change

})

it("should not incorrectly detect non-Azure URLs with /openai/deployments/ path", () => {

const nonAzureHandler = new OpenAiHandler({

...mockOptions,

openAiBaseUrl: "https://custom-api.com/openai/deployments/model",

})

// Verify behavior - should it detect as Azure or not?

expect(nonAzureHandler).toBeInstanceOf(OpenAiHandler)

})

daniel-lxs · 2025-09-01T23:01:56Z

I'm not sure if this will deal with the issue if the user is providing a custom URL

roomote bot requested review from cte, jr and mrubens as code owners August 28, 2025 17:20

github-project-automation bot added this to Roo Code Roadmap and Roo Code Roadmap Aug 28, 2025

github-project-automation bot moved this to New in Roo Code Roadmap Aug 28, 2025

github-project-automation bot moved this to Triage in Roo Code Roadmap Aug 28, 2025

dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. bug Something isn't working labels Aug 28, 2025

ellipsis-dev bot reviewed Aug 28, 2025

View reviewed changes

roomote bot commented Aug 28, 2025

View reviewed changes

roomote bot mentioned this pull request Aug 28, 2025

Error 404 in Roo-Code, but Replicable using openai in python #7498

Closed

hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Aug 28, 2025

daniel-lxs moved this from Triage to PR [Needs Prelim Review] in Roo Code Roadmap Aug 29, 2025

hannesrudolph added PR - Needs Preliminary Review and removed Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. labels Aug 29, 2025

daniel-lxs closed this Sep 1, 2025

github-project-automation bot moved this from PR [Needs Prelim Review] to Done in Roo Code Roadmap Sep 1, 2025

github-project-automation bot moved this from New to Done in Roo Code Roadmap Sep 1, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: improve Azure OpenAI detection and update API version for o3 models #7499

fix: improve Azure OpenAI detection and update API version for o3 models #7499

Uh oh!

roomote bot commented Aug 28, 2025 •

edited by ellipsis-dev bot

Loading

Uh oh!

ellipsis-dev bot Aug 28, 2025

Uh oh!

roomote bot left a comment

Uh oh!

roomote bot Aug 28, 2025

Uh oh!

roomote bot Aug 28, 2025

Uh oh!

roomote bot Aug 28, 2025

Uh oh!

roomote bot Aug 28, 2025

Uh oh!

daniel-lxs commented Sep 1, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

-	private _isAzureOpenAi(baseUrl?: string): boolean {
+	/**
+	 * Detects if the provided base URL is an Azure OpenAI endpoint
+	 * @param baseUrl - The API base URL to check
+	 * @returns true if the URL matches Azure OpenAI patterns:
+	 *   - Domains ending with .openai.azure.com
+	 *   - URLs containing /openai/deployments/ path
+	 *   - Domains ending with .azure.com
+	 */
+	private _isAzureOpenAi(baseUrl?: string): boolean {

-		})
+		it("should not incorrectly detect non-Azure URLs with /openai/deployments/ path", () => {
+			const nonAzureHandler = new OpenAiHandler({
+				...mockOptions,
+				openAiBaseUrl: "https://custom-api.com/openai/deployments/model",
+			})
+			// Verify behavior - should it detect as Azure or not?
+			expect(nonAzureHandler).toBeInstanceOf(OpenAiHandler)
+		})

fix: improve Azure OpenAI detection and update API version for o3 models #7499

fix: improve Azure OpenAI detection and update API version for o3 models #7499

Uh oh!

Conversation

roomote bot commented Aug 28, 2025 • edited by ellipsis-dev bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Problem

Root Cause

Solution

1. Updated Azure API Version

2. Enhanced Azure Detection Logic

3. Added Comprehensive Tests

Testing

Related Issues

Uh oh!

ellipsis-dev bot Aug 28, 2025

Choose a reason for hiding this comment

Uh oh!

roomote bot left a comment

Choose a reason for hiding this comment

Uh oh!

roomote bot Aug 28, 2025

Choose a reason for hiding this comment

Uh oh!

roomote bot Aug 28, 2025

Choose a reason for hiding this comment

Uh oh!

roomote bot Aug 28, 2025

Choose a reason for hiding this comment

Uh oh!

roomote bot Aug 28, 2025

Choose a reason for hiding this comment

Uh oh!

daniel-lxs commented Sep 1, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

roomote bot commented Aug 28, 2025 •

edited by ellipsis-dev bot

Loading