Fix: Preserve OpenRouter experimental settings when switching API profiles #7502
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…files - Modified activateProviderProfile to preserve openRouterImageGenerationSettings - Added tests to verify the fix works correctly - Ensures experimental image generation settings are not lost during profile switches
dosubot
bot
added
size:L
![roomote[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
| // Preserve openRouterImageGenerationSettings if it exists in current settings | ||
| // This ensures experimental settings like the image generation API key are not lost | ||
| if (currentSettings.openRouterImageGenerationSettings) { | ||
| providerSettings.openRouterImageGenerationSettings = currentSettings.openRouterImageGenerationSettings |
Contributor
Author
There was a problem hiding this comment.
Nice work preserving the experimental settings! Though I wonder if we should consider a more generic approach for preserving certain settings during profile switches in the future? This pattern might be useful for other experimental/optional settings.
| openRouterApiKey: "test-experimental-key", | ||
| selectedModel: "dall-e-3", | ||
| }, | ||
| }) |
Contributor
Author
There was a problem hiding this comment.
Comprehensive test coverage here! Both the positive case (settings exist) and negative case (no settings) are well covered. The mocking setup is thorough and the assertions verify the expected behavior correctly.
hannesrudolph
added
the
Issue/PR - Triage
hannesrudolph
added
PR - Needs Preliminary Review
and removed
Issue/PR - Triage
Collaborator
|
Tested this and it works. |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
github-project-automation
bot
moved this from PR [Needs Prelim Review]
to Done
in Roo Code Roadmap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue where the OpenRouter API Key field under Experimental settings loses its value when switching between API profiles.
Problem
When users switch between API profiles, the object (which contains the experimental image generation API key and selected model) was being lost because the method was completely overwriting the provider settings without preserving experimental settings.
Solution
Modified the method in to:
Testing
Impact
This fix ensures users don't lose their OpenRouter API key configuration when switching between different API profiles, improving the user experience for those using the experimental image generation feature.
Fixes #[issue-number]
Important
Fixes issue in
ClineProvider.tsto preserveopenRouterImageGenerationSettingswhen switching API profiles, with new tests added to verify the fix.ClineProvider.tswhereopenRouterImageGenerationSettingswere lost when switching API profiles.activateProviderProfile()to preserveopenRouterImageGenerationSettingsif they exist in current settings.ClineProvider.spec.tsto verify preservation of experimental settings when switching profiles.This description was created by
for 1a727b5. You can customize this summary. It will automatically update as commits are pushed.