Sync extension bridge settings with cloud

[jr]

Important

Sync remoteControlEnabled setting with cloud, making cloud the source of truth, and improve error handling for cloud interactions.

• Behavior:
  • remoteControlEnabled setting in ClineProvider.ts now fetched from cloud settings using CloudService.instance.getUserSettings().
  • In webviewMessageHandler.ts, updates to remoteControlEnabled now update cloud settings via CloudService.instance.updateUserSettings().
  • extension.ts updates ExtensionBridgeService with remoteControlEnabled from cloud settings.
• Error Handling:
  • Improved error logging for cloud setting fetch failures in ClineProvider.ts and extension.ts.
• Misc:
  • Removed default value for remoteControlEnabled in ClineProvider.ts.

^{This description was created by for dace718. You can customize this summary. It will automatically update as commits are pushed.}

[roomote]

Thank you for your contribution! I've reviewed the changes and found several issues that need attention before this can be merged.

[roomote]

Is this intentional? The error handling here only logs the error but doesn't provide any fallback value for remoteControlEnabled. If getUserSettings() returns null/undefined, the remote control state could be out of sync.

Consider ensuring the fallback value is always applied.

[roomote]

This logic for determining remoteControlEnabled is duplicated from lines 144-146. Could we extract this into a helper function to avoid duplication?

For example:

function getRemoteControlEnabled(isCloudAgent: boolean): boolean {
    return isCloudAgent ? true : (CloudService.instance.getUserSettings()?.settings?.extensionBridgeEnabled ?? false);
}

[roomote]

Missing null check - what happens if CloudService is not initialized yet? The code uses optional chaining but doesn't verify that CloudService.instance exists.

Consider adding a hasInstance() check before accessing the instance.

[roomote]

The error is only logged but doesn't provide user feedback. Should we show an error message to the user when cloud settings fail to update?

Consider adding a user-facing error notification.