-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Refactor the extension bridge #7515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this excellent refactoring! The new BridgeOrchestrator architecture with separated channels is much cleaner and the consolidated logging improves readability. I've left some suggestions for consideration, mainly around error handling and potential memory management improvements.
|
Hi @cte , Thanks for clarifying! |
Important
Refactor extension bridge system by introducing
BridgeOrchestratorand related components, replacingExtensionBridgeServicefor improved communication management.BridgeOrchestratorto manage communication between VSCode extension and web app, replacingExtensionBridgeService.BaseChannel,ExtensionChannel, andTaskChannelfor structured communication.McpHubandMdmServiceto integrate with new bridge system.BaseChannel.ts,BridgeOrchestrator.ts,ExtensionChannel.ts, andTaskChannel.ts.ExtensionBridgeService.ts,ExtensionManager.ts, andTaskManager.ts.SocketConnectionManager.tstoSocketTransport.ts.ExtensionChannelandTaskChannelin__tests__directory.webviewMessageHandler.tsandextension.tsto useBridgeOrchestrator.isRemoteControlEnabledutility function.This description was created by
for 8079f74. You can customize this summary. It will automatically update as commits are pushed.