Skip to content

fix: add OpenEdge ABL file extensions support for codebase indexing #7522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix: add OpenEdge ABL file extensions support for codebase indexing #7522

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/services/code-index/shared/supported-extensions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,9 @@ export const fallbackExtensions = [
".vb", // Visual Basic .NET - no dedicated WASM parser
".scala", // Scala - uses fallback chunking instead of Lua query workaround
".swift", // Swift - uses fallback chunking due to parser instability
".p", // OpenEdge ABL - no dedicated WASM parser
".i", // OpenEdge ABL include file - no dedicated WASM parser
Copy link
Contributor Author

@roomote roomote bot Aug 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These comments could be more descriptive to help future maintainers. For example, instead of just "OpenEdge ABL include file", consider "OpenEdge ABL include file - contains shared definitions and procedures". Would this additional context be helpful?

".w", // OpenEdge ABL window file - no dedicated WASM parser
]

/**
Expand Down
4 changes: 4 additions & 0 deletions src/services/tree-sitter/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,10 @@ const extensions = [
"erb",
// Visual Basic .NET
"vb",
// OpenEdge ABL
"p",
Copy link
Contributor Author

@roomote roomote bot Aug 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this formatting intentional? Other multi-extension languages like C/C++ (lines 41-46) use a single comment above the extensions. Consider:

"i",
"w",
].map((e) => `.${e}`)

export { extensions }
Expand Down
Loading