Skip to content

Handle images in roolease notes #7548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Handle images in roolease notes #7548

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b0ee56d
Handle images in roolease notes
mrubens Aug 30, 2025
f8051e8
More image types
mrubens Aug 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/marketplace-publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,10 @@ jobs:
changelog_content="Release v${current_package_version}"
else
echo "Found changelog section for version ${current_package_version}"
# Convert relative image paths to full GitHub URLs for proper display in release notes
# Use the main branch URL since the images will be merged there before release
# Only match .png files to avoid accidentally modifying other references
changelog_content=$(echo "$changelog_content" | sed "s|(releases/\([^)]*\.png\))|(https://github.com/${{ github.repository }}/raw/main/releases/\1)|g")
Copy link
Contributor

@roomote roomote bot Aug 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider supporting more image formats beyond just PNG. You could modify this to:

This would handle .jpg, .jpeg, .gif, and .svg files as well.

Copy link
Collaborator Author

@mrubens mrubens Aug 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@roomote-agent good point, make it handle those types too

Copy link
Contributor

@roomote roomote bot Aug 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the hardcoded 'main' branch assumption always valid? If a release is created from a different branch or tag, the images might not be accessible. Could we use the actual release tag or branch instead?

For example, you could use:

This would reference the images from the release tag itself.

fi

# Create release with changelog content
Expand Down
1 change: 1 addition & 0 deletions .roo/commands/release.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,4 +41,5 @@ argument-hint: patch | minor | major
11. The GitHub Actions workflow will automatically:
- Create a version bump PR when changesets are merged to main
- Update the CHANGELOG.md with proper formatting
- Convert PNG image paths in release notes to GitHub raw URLs for proper display
- Publish the release when the version bump PR is merged
Loading