Skip to content

fix: resolve IconButton onClick handler issue preventing clicks #7553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix: resolve IconButton onClick handler issue preventing clicks #7553

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion webview-ui/src/components/chat/IconButton.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ export const IconButton: React.FC<IconButtonProps> = ({
className,
)}
disabled={disabled}
onClick={!disabled ? onClick : undefined}
onClick={onClick}
Copy link
Contributor Author

@roomote roomote bot Aug 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix looks correct - removing the conditional onClick handler and relying on the native button's disabled attribute is the right approach. This simplifies the code and fixes the issue where buttons weren't responding to clicks.

A few observations for future consideration:

  1. Would it be worth adding tests for this component to prevent regression?
  2. I noticed there's another IconButton in webview-ui/src/components/common/IconButton.tsx - is this duplication intentional?
  3. Consider adding a comment explaining why conditional onClick isn't needed with the disabled attribute.

style={{ fontSize: 16.5, ...style }}
{...props}>
<span className={cn("codicon", iconClass, isLoading && "codicon-modifier-spin")} />
Expand Down
Loading