Remove unused slack notif #7655
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:S
![roomote[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
| run: echo "OPENROUTER_API_KEY=${{ secrets.OPENROUTER_API_KEY }}" > .env.local | ||
| - name: Run integration tests | ||
| working-directory: apps/vscode-e2e | ||
| run: xvfb-run -a pnpm test:ci |
Contributor
There was a problem hiding this comment.
Good catch removing this unused Slack notification job! However, I noticed that the .github/actions/slack-notify/action.yml file is now orphaned since this was its only usage. Would it make sense to also remove that action file as part of this cleanup?
I verified that the slack-notify action isn't being used anywhere else in the workflows, so removing it would help keep the codebase tidy.
hannesrudolph
added
the
Issue/PR - Triage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Remove unused Slack notification job from
code-qa.ymlworkflow.notify-slack-on-failurejob from.github/workflows/code-qa.yml.check-translations,knip,compile,unit-test,integration-test).This description was created by
for e58d260. You can customize this summary. It will automatically update as commits are pushed.