-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Feature/update vertex ai models and regions #7727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/update vertex ai models and regions #7727
Conversation
…issing region - Add gpt-oss-120b-maas, gpt-oss-20b-maas, deepseek-r1-0528-maas, deepseek-v3.1-maas, qwen3-coder-480b-a35b-instruct-maas, qwen3-235b-a22b-instruct-2507-maas to vertexAI provider - Add us-south1 to vertex AI regions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution! I've reviewed the changes and the PR successfully addresses the issue by adding all 6 requested Vertex AI models and the us-south1 region. The implementation is clean and follows existing patterns. I have one question about region availability that might be worth clarifying.
| supportsPromptCache: false, | ||
| inputPrice: 0.6, | ||
| outputPrice: 1.7, | ||
| description: "DeepSeek V3.1. Available in us-west2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed the description mentions "Available in us-west2" while the other DeepSeek model (deepseek-r1-0528-maas) mentions us-central1. Is this intentional? The issue #7725 mentioned these models need us-south1 support, so I wanted to confirm if this model is actually available in us-west2 or if it should be us-south1 instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call out. This is intentional. Google Vertex AI models are not always global so you have to know which region is required for each model, and there is no pattern to it. Each requires manually finding the right model page in Google Vertex AI's model garden listings.
These values are provided here for significant convenience and better UX flow. By leveraging the description field, it presents the value in a context-relevant, (IMO) appropriate location without building some new Vertex-only field, and helps the user keep flow and not be required to go hunt down these values and leave their current UX setting. This should be a major convenience. All values provided are manually verified in the Google Vertex documentation, sample here: https://cloud.google.com/vertex-ai/generative-ai/docs/maas/deepseek/deepseek-v31
mrubens
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Related GitHub Issue
Closes: #7725
Roo Code Task Context (Optional)
Description
This PR attempts to address Issue #7725 by adding the missing Vertex AI models and the us-south1 region.
Added Models
Added Region
Updated provider test
Test Procedure
Open settings > Providers.
Select GCP Vertex AI.
Verified us-south1 shows up the the Google Cloud Region dropdown.
Verified the new models showed up in the Model dropdown.
Verified the prices and context settings against the Vertex model pages.
Ran npm test and verified the new region clears the region checks.
Pre-Submission Checklist
Screenshots / Videos
Documentation Updates
Additional Notes
Get in Touch
Important
Add new Vertex AI models and
us-south1region, update tests accordingly.deepseek-r1-0528-maas,deepseek-v3.1-maas,gpt-oss-120b-maas,gpt-oss-20b-maas,qwen3-coder-480b-a35b-instruct-maas,qwen3-235b-a22b-instruct-2507-maastovertexModelsinvertex.ts.us-south1toVERTEX_REGIONSinvertex.ts.Vertex.spec.tsxto includeus-south1in region tests.This description was created by
for 3b90450. You can customize this summary. It will automatically update as commits are pushed.