Skip to content

Conversation

@ssweens
Copy link
Contributor

@ssweens ssweens commented Sep 6, 2025

Related GitHub Issue

Closes: #7725

Roo Code Task Context (Optional)

Description

This PR attempts to address Issue #7725 by adding the missing Vertex AI models and the us-south1 region.

Added Models

gpt-oss-120b-maas - GPT OSS 120B model via Model-as-a-Service
gpt-oss-20b-maas - GPT OSS 20B model via Model-as-a-Service
deepseek-r1-0528-maas - DeepSeek R1 0528 model via Model-as-a-Service
deepseek-v3.1-maas - DeepSeek V3.1 model via Model-as-a-Service
qwen3-coder-480b-a35b-instruct-maas - Qwen3 Coder 480B Instruct model via Model-as-a-Service
qwen3-235b-a22b-instruct-2507-maas - Qwen3 235B Instruct model via Model-as-a-Service

Added Region

us-south1 - Added to VERTEX_REGIONS array for qwen models support

Updated provider test

added us-south1 as valid region

Test Procedure

Open settings > Providers.
Select GCP Vertex AI.
Verified us-south1 shows up the the Google Cloud Region dropdown.
Verified the new models showed up in the Model dropdown.
Verified the prices and context settings against the Vertex model pages.
Ran npm test and verified the new region clears the region checks.

Pre-Submission Checklist

  • Issue Linked: This PR is linked to an approved GitHub Issue (see "Related GitHub Issue" above).
  • [ X] Scope: My changes are focused on the linked issue (one major feature/fix per PR).
  • [ X] Self-Review: I have performed a thorough self-review of my code.
  • [ X] Testing: New and/or updated tests have been added to cover my changes (if applicable).
  • [ X] Documentation Impact: I have considered if my changes require documentation updates (see "Documentation Updates" section below).
  • [X ] Contribution Guidelines: I have read and agree to the Contributor Guidelines.

Screenshots / Videos

Documentation Updates

Additional Notes

Get in Touch


Important

Add new Vertex AI models and us-south1 region, update tests accordingly.

  • Models:
    • Added deepseek-r1-0528-maas, deepseek-v3.1-maas, gpt-oss-120b-maas, gpt-oss-20b-maas, qwen3-coder-480b-a35b-instruct-maas, qwen3-235b-a22b-instruct-2507-maas to vertexModels in vertex.ts.
  • Regions:
    • Added us-south1 to VERTEX_REGIONS in vertex.ts.
  • Tests:
    • Updated Vertex.spec.tsx to include us-south1 in region tests.

This description was created by Ellipsis for 3b90450. You can customize this summary. It will automatically update as commits are pushed.

…issing region

- Add gpt-oss-120b-maas, gpt-oss-20b-maas, deepseek-r1-0528-maas, deepseek-v3.1-maas, qwen3-coder-480b-a35b-instruct-maas, qwen3-235b-a22b-instruct-2507-maas to vertexAI provider
- Add us-south1 to vertex AI regions
@ssweens ssweens requested review from cte, jr and mrubens as code owners September 6, 2025 02:19
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. enhancement New feature or request labels Sep 6, 2025
Copy link
Contributor

@roomote roomote bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! I've reviewed the changes and the PR successfully addresses the issue by adding all 6 requested Vertex AI models and the us-south1 region. The implementation is clean and follows existing patterns. I have one question about region availability that might be worth clarifying.

supportsPromptCache: false,
inputPrice: 0.6,
outputPrice: 1.7,
description: "DeepSeek V3.1. Available in us-west2",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed the description mentions "Available in us-west2" while the other DeepSeek model (deepseek-r1-0528-maas) mentions us-central1. Is this intentional? The issue #7725 mentioned these models need us-south1 support, so I wanted to confirm if this model is actually available in us-west2 or if it should be us-south1 instead?

Copy link
Contributor Author

@ssweens ssweens Sep 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call out. This is intentional. Google Vertex AI models are not always global so you have to know which region is required for each model, and there is no pattern to it. Each requires manually finding the right model page in Google Vertex AI's model garden listings.

These values are provided here for significant convenience and better UX flow. By leveraging the description field, it presents the value in a context-relevant, (IMO) appropriate location without building some new Vertex-only field, and helps the user keep flow and not be required to go hunt down these values and leave their current UX setting. This should be a major convenience. All values provided are manually verified in the Google Vertex documentation, sample here: https://cloud.google.com/vertex-ai/generative-ai/docs/maas/deepseek/deepseek-v31

@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Sep 6, 2025
Copy link
Collaborator

@mrubens mrubens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 7, 2025
@mrubens mrubens merged commit 18cf33f into RooCodeInc:main Sep 7, 2025
22 checks passed
@github-project-automation github-project-automation bot moved this from Triage to Done in Roo Code Roadmap Sep 7, 2025
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Sep 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.