Skip to content

fix: increase z-index of context menu to prevent UI obstruction #7760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix: increase z-index of context menu to prevent UI obstruction #7760

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion webview-ui/src/components/chat/ChatTextArea.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -954,7 +954,7 @@ export const ChatTextArea = forwardRef<HTMLTextAreaElement, ChatTextAreaProps>(
"bottom-full",
"left-0",
"right-0",
"z-[1000]",
"z-[10001]",
Copy link
Contributor Author

@roomote roomote bot Sep 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I notice we're using Tailwind class here, but in ContextMenu.tsx we're using inline style . Should we consider using a consistent approach across both files? Tailwind classes would be preferable for maintainability.

"mb-2",
"filter",
"drop-shadow-md",
Expand Down
2 changes: 1 addition & 1 deletion webview-ui/src/components/chat/ContextMenu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,7 +268,7 @@ const ContextMenu: React.FC<ContextMenuProps> = ({
border: "1px solid var(--vscode-editorGroup-border)",
borderRadius: "3px",
boxShadow: "0 4px 10px rgba(0, 0, 0, 0.25)",
zIndex: 1000,
zIndex: 10001,
Copy link
Contributor Author

@roomote roomote bot Sep 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The jump from z-index 1000 to 10001 seems quite large. Looking at the codebase, modals use , so this context menu at 10001 is 10x higher. Could we consider establishing a more structured z-index scale? For example:

  • Dropdowns: 1000-1999
  • Modals: 2000-2999
  • Tooltips/Context menus: 3000-3999

This would make the hierarchy clearer and prevent future conflicts.

display: "flex",
flexDirection: "column",
maxHeight: "300px",
Expand Down
Loading