-
Notifications
You must be signed in to change notification settings - Fork 2.4k
chore(deps): update dependency @types/react to v18.3.26 #7763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this dependency update! However, I found an issue that needs to be addressed: the package.json files haven't been updated to match the lockfile changes.
| @@ -241,10 +241,10 @@ importers: | |||
| version: 1.1.6 | |||
| '@types/react': | |||
| specifier: ^18.3.23 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The lockfile has been updated to use @types/react version 18.3.24, but the package.json files in the following locations still reference version ^18.3.23:
- apps/web-evals/package.json (line 55)
- webview-ui/package.json (line 91)
- apps/web-roo-code/package.json (line 43)
Could you please update these package.json files to specify "@types/react": "^18.3.24" to maintain consistency between the package manifests and the lockfile? This inconsistency could lead to version conflicts and unexpected behavior.
a02fd83 to
e895bb1
Compare
e1e81d6 to
5ee444b
Compare
c7cfccc to
da6f279
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No new issues found - all concerns already addressed in existing comments.
5208305 to
4097c7b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found some issues that need attention. See inline comment(s).
| undici-types: 7.10.0 | ||
|
|
||
| '@types/[email protected].14': {} | ||
| '@types/[email protected].15': {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[P3] The lockfile also bumps '@types/prop-types' to 15.7.15 as a transitive effect of the @types/react update. If your policy is to keep PR titles/descriptions aligned with all direct changes, consider acknowledging this extra type bump; otherwise safe to keep.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No new issues found - all concerns already addressed in existing comments.
4097c7b to
a34a6f7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No new issues found - all concerns already addressed in existing comments.
a7c6eb0 to
dd4c6bf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No new issues found - all concerns already addressed in existing comments.
697b0f0 to
f9d24d5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No new issues found - all concerns already addressed in existing comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No new issues found - all concerns already addressed in existing comments.
f9d24d5 to
7333e8c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found some issues that need attention. See inline comment(s).
| version: 18.3.23 | ||
| version: 18.3.26 | ||
| '@types/react-dom': | ||
| specifier: ^18.3.5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[P2] Inconsistent @types/react-dom specifiers across workspaces. The lockfile resolves to 18.3.7, but package.json manifests specify different ranges: apps/web-evals and webview-ui use ^18.3.5 while apps/web-roo-code uses ^18.3.7. Recommend aligning all manifests to ^18.3.7 (or a single ^18.3.x) to avoid drift and ensure consistent installs: - apps/web-evals/package.json line 56 -> "@types/react-dom": "^18.3.7" - webview-ui/package.json line 94 -> "@types/react-dom": "^18.3.7" - apps/web-roo-code/package.json line 46 is already ^18.3.7.
7333e8c to
7fb0982
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No new issues found - all concerns already addressed in existing comments.
7fb0982 to
bab7d4c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No new issues found - all concerns already addressed in existing comments.
bab7d4c to
110941d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The previous review incorrectly identified an issue with package.json files not being updated. This is actually correct behavior: the package.json files specify ^18.3.23 for @types/react, which means 'compatible with 18.3.23'. The lockfile correctly resolves this to 18.3.26, which is a valid patch update within the semver range. No package.json changes are needed for this type of dependency update.
110941d to
8ac5a34
Compare
Review CompleteNo new issues found. This is a standard automated dependency update that bumps Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues. |
8ac5a34 to
ee66584
Compare
This PR contains the following updates:
18.3.23->18.3.26Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.