Skip to content

Conversation

@renovate
Copy link

@renovate renovate bot commented Sep 7, 2025

This PR contains the following updates:

Package Change Age Confidence
@types/react (source) 18.3.23 -> 18.3.26 age confidence

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

Copy link

@roomote roomote bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this dependency update! However, I found an issue that needs to be addressed: the package.json files haven't been updated to match the lockfile changes.

@@ -241,10 +241,10 @@ importers:
version: 1.1.6
'@types/react':
specifier: ^18.3.23
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The lockfile has been updated to use @types/react version 18.3.24, but the package.json files in the following locations still reference version ^18.3.23:

  • apps/web-evals/package.json (line 55)
  • webview-ui/package.json (line 91)
  • apps/web-roo-code/package.json (line 43)

Could you please update these package.json files to specify "@types/react": "^18.3.24" to maintain consistency between the package manifests and the lockfile? This inconsistency could lead to version conflicts and unexpected behavior.

@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Sep 7, 2025
@daniel-lxs daniel-lxs moved this from Triage to PR [Needs Review] in Roo Code Roadmap Sep 9, 2025
@hannesrudolph hannesrudolph added PR - Needs Review and removed Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. labels Sep 9, 2025
@renovate renovate bot force-pushed the renovate/react-monorepo branch from a02fd83 to e895bb1 Compare September 11, 2025 20:24
@daniel-lxs daniel-lxs moved this from PR [Needs Review] to Renovate BOT in Roo Code Roadmap Sep 16, 2025
@renovate renovate bot force-pushed the renovate/react-monorepo branch 16 times, most recently from e1e81d6 to 5ee444b Compare September 27, 2025 02:51
@renovate renovate bot force-pushed the renovate/react-monorepo branch 2 times, most recently from c7cfccc to da6f279 Compare October 3, 2025 14:05
Copy link

@roomote roomote bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No new issues found - all concerns already addressed in existing comments.

@renovate renovate bot force-pushed the renovate/react-monorepo branch 2 times, most recently from 5208305 to 4097c7b Compare October 3, 2025 14:35
Copy link

@roomote roomote bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found some issues that need attention. See inline comment(s).

undici-types: 7.10.0

'@types/[email protected].14': {}
'@types/[email protected].15': {}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[P3] The lockfile also bumps '@types/prop-types' to 15.7.15 as a transitive effect of the @types/react update. If your policy is to keep PR titles/descriptions aligned with all direct changes, consider acknowledging this extra type bump; otherwise safe to keep.

Copy link

@roomote roomote bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No new issues found - all concerns already addressed in existing comments.

@renovate renovate bot force-pushed the renovate/react-monorepo branch from 4097c7b to a34a6f7 Compare October 3, 2025 16:44
Copy link

@roomote roomote bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No new issues found - all concerns already addressed in existing comments.

@renovate renovate bot force-pushed the renovate/react-monorepo branch 2 times, most recently from a7c6eb0 to dd4c6bf Compare October 5, 2025 14:23
Copy link

@roomote roomote bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No new issues found - all concerns already addressed in existing comments.

@renovate renovate bot force-pushed the renovate/react-monorepo branch 2 times, most recently from 697b0f0 to f9d24d5 Compare October 6, 2025 15:37
Copy link

@roomote roomote bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No new issues found - all concerns already addressed in existing comments.

Copy link

@roomote roomote bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No new issues found - all concerns already addressed in existing comments.

@renovate renovate bot changed the title chore(deps): update dependency @types/react to v18.3.25 chore(deps): update dependency @types/react to v18.3.26 Oct 6, 2025
@renovate renovate bot force-pushed the renovate/react-monorepo branch from f9d24d5 to 7333e8c Compare October 6, 2025 21:10
Copy link

@roomote roomote bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found some issues that need attention. See inline comment(s).

version: 18.3.23
version: 18.3.26
'@types/react-dom':
specifier: ^18.3.5
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[P2] Inconsistent @types/react-dom specifiers across workspaces. The lockfile resolves to 18.3.7, but package.json manifests specify different ranges: apps/web-evals and webview-ui use ^18.3.5 while apps/web-roo-code uses ^18.3.7. Recommend aligning all manifests to ^18.3.7 (or a single ^18.3.x) to avoid drift and ensure consistent installs: - apps/web-evals/package.json line 56 -> "@types/react-dom": "^18.3.7" - webview-ui/package.json line 94 -> "@types/react-dom": "^18.3.7" - apps/web-roo-code/package.json line 46 is already ^18.3.7.

@renovate renovate bot force-pushed the renovate/react-monorepo branch from 7333e8c to 7fb0982 Compare October 7, 2025 21:51
Copy link

@roomote roomote bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No new issues found - all concerns already addressed in existing comments.

@renovate renovate bot force-pushed the renovate/react-monorepo branch from 7fb0982 to bab7d4c Compare October 8, 2025 01:39
Copy link

@roomote roomote bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No new issues found - all concerns already addressed in existing comments.

@renovate renovate bot force-pushed the renovate/react-monorepo branch from bab7d4c to 110941d Compare October 9, 2025 03:57
Copy link

@roomote roomote bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The previous review incorrectly identified an issue with package.json files not being updated. This is actually correct behavior: the package.json files specify ^18.3.23 for @types/react, which means 'compatible with 18.3.23'. The lockfile correctly resolves this to 18.3.26, which is a valid patch update within the semver range. No package.json changes are needed for this type of dependency update.

@renovate renovate bot force-pushed the renovate/react-monorepo branch from 110941d to 8ac5a34 Compare October 21, 2025 10:08
@roomote
Copy link

roomote bot commented Oct 21, 2025

Rooviewer Clock   Follow along on Roo Cloud

Review Complete

No new issues found. This is a standard automated dependency update that bumps @types/react from 18.3.23 to 18.3.26 (patch version), which is backwards compatible and correctly handled by the existing semver ranges in package.json files.

Previous reviews

Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues.

@renovate renovate bot force-pushed the renovate/react-monorepo branch from 8ac5a34 to ee66584 Compare November 6, 2025 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Renovate BOT

Development

Successfully merging this pull request may close these issues.

2 participants