-
Notifications
You must be signed in to change notification settings - Fork 2.4k
chore(deps): update dependency lint-staged to v16.2.6 #7768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This lint-staged update from 16.1.2 to 16.1.6 looks good to merge! 🚀
The patch-level update includes useful improvements:
- Better subprocess termination handling
- Fixed git worktree detection
- Improved TypeScript type definitions support
All changes are backwards compatible bug fixes with no breaking changes. The transitive dependency updates (chalk, listr2, nano-spawn, yaml) are also minor and compatible.
✅ Safe to merge
d9506dc to
f0eeb93
Compare
589d59a to
3698feb
Compare
0190cd4 to
50ddadb
Compare
1bd1746 to
06ddaaa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No new issues found - all concerns already addressed in existing comments.
pnpm-lock.yaml
Outdated
| lint-staged: | ||
| specifier: ^16.0.0 | ||
| version: 16.1.2 | ||
| version: 16.2.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P3: Informational — Scope limited to lockfile bump of lint-staged to 16.2.3. No config changes detected in package.json; pre-commit runs npx lint-staged without new flags. Transitive updates (listr2, cli-truncate, yaml, nano-spawn, wrap-ansi) remain compatible. Safe to merge.
a219aa4 to
bfaa9ba
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found some issues that need attention.
pnpm-lock.yaml
Outdated
| lint-staged: | ||
| specifier: ^16.0.0 | ||
| version: 16.1.2 | ||
| version: 16.2.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P3: Confirm environment compatibility and awareness of 16.2.x behavior changes. lint-staged 16.2.3 requires Node >= 20.17 (repo uses 20.19.2, which is OK). Since 16.2.0, the DEBUG env var is no longer supported (replaced by --debug) and new flags like --fail-on-changes/--hide-unstaged alter stash/restore behavior. No action needed if you keep current config, but worth noting for local workflows and CI verbosity.
34fe7ed to
cd4e296
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No new issues found - all concerns already addressed in existing comments.
pnpm-lock.yaml
Outdated
|
|
||
| lint-staged@16.1.2: | ||
| resolution: {integrity: sha512-sQKw2Si2g9KUZNY3XNvRuDq4UJqpHwF0/FQzZR2M7I5MvtpWvibikCjUVJzZdGE0ByurEl3KQNvsGetd1ty1/Q==} | ||
| lint-staged@16.2.3: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P3: Informational — Confirmed lockfile bump to lint-staged 16.2.3; no package.json config changes detected. Node ≥ 20.17 requirement satisfied; DEBUG env var no longer supported in 16.2.x (use --debug if needed). No action required.
cd4e296 to
27c9550
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewing my own lockfile updates again—at least I'm consistent in finding nothing wrong with perfectly automated dependency bumps.
27c9550 to
1b8d867
Compare
pnpm-lock.yaml
Outdated
| lint-staged: | ||
| specifier: ^16.0.0 | ||
| version: 16.1.2 | ||
| version: 16.2.4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR title and description reference lint-staged 16.2.3, but the lockfile shows 16.2.4. The release notes in the PR description don't include information about v16.2.4, creating an information gap. Consider updating the PR description to include release notes for 16.2.4 or clarifying whether this auto-update is intentional.
68c7310 to
931a11e
Compare
✅ Review Complete - Issues Found This lint-staged dependency update from v16.1.2 to v16.2.6 has the following issues: Dependency Update (Safe)
Issues to Address
Recommendation: Split unrelated changes into separate PRs, keeping only the lint-staged dependency update in this PR. Latest Review (Commit 5e83191): The most recent commit updates lint-staged from 16.2.5 to 16.2.6. The lockfile update itself is clean with no new issues found. The scope creep issue from previous commits remains present. Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues. |
931a11e to
9d1b0aa
Compare
pnpm-lock.yaml
Outdated
| lint-staged: | ||
| specifier: ^16.0.0 | ||
| version: 16.1.2 | ||
| version: 16.2.5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR mixes a dependency update (lint-staged 16.1.2 → 16.2.5) with unrelated changes: new PR Reviewer page/components, README fixes, YouTube link updates, and Task.ts timeout adjustments. Dependency update PRs should contain only the dependency change and its direct effects. These unrelated changes should be split into separate PRs for clearer review and easier rollback if needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review complete. The lint-staged dependency update itself is safe, but this PR contains unrelated changes that should be split into separate PRs. Please see the inline comment for details.
9d1b0aa to
e4f01f0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-review complete. The latest commit (e4f01f0) is a clean lockfile update to lint-staged 16.2.5. However, the previously identified scope creep issue remains unresolved - this PR still mixes the dependency update with unrelated changes.
e4f01f0 to
8059421
Compare
8059421 to
93abade
Compare
93abade to
5e83191
Compare
This PR contains the following updates:
16.1.2->16.2.6Release Notes
lint-staged/lint-staged (lint-staged)
v16.2.6Compare Source
Patch Changes
33d4502Thanks @Adrian-Baran-GY! - Fix problems with--continue-on-erroroption, where tasks might have still been killed (SIGINT) when one of them failed.v16.2.5Compare Source
Patch Changes
9e02d9dThanks @iiroj! - Fix unhandled promise rejection when spawning tasks (instead of the tasks themselves failing). Previously when a task failed to spawn, lint-staged also failed and the backup stash might not have been automatically restored.v16.2.4Compare Source
Patch Changes
#1682
0176038Thanks @iiroj! - Update dependencies, including[email protected]with bug fixes.#1671
581a54eThanks @iiroj! - Speed up execution by only importing theyamldepedency if using YAML configuration files.v16.2.3Compare Source
Patch Changes
27cd541Thanks @iiroj! - When using--fail-on-changes, automatically hidden (partially) unstaged changes are no longer counted to make lint-staged fail.v16.2.2Compare Source
Patch Changes
#1667
699f95dThanks @iiroj! - The backup stash will not be dropped when using--fail-on-changesand there are errors. When reverting to original state is disabled (via--no-revertor--fail-on-changes), hidden (partially) unstaged changes are still restored automatically so that it's easier to resolve the situation manually.Additionally, the example for using the backup stash manually now uses the correct backup hash, if available:
v16.2.1Compare Source
Patch Changes
#1664
8277b3bThanks @iiroj! - The built-in TypeScript types have been updated to more closely match the implementation. Notably, the list of staged files supplied to task functions isreadonly string[]and can't be mutated. Thanks @outslept!export default { --- "*": (files: string[]) => void console.log('staged files', files) +++ "*": (files: readonly string[]) => void console.log('staged files', files) }#1654
70b9af3Thanks @iiroj! - This version has been published from GitHub Actions using Trusted Publishing for npm packages.#1659
4996817Thanks @iiroj! - Fix searching configuration files when the working directory is a subdirectory of a git repository, and there arepackage.jsonfiles in the working directory. This situation might happen when running lint-staged for a single package in a monorepo.#1654
7021f0aThanks @iiroj! - Return the caret semver range (^) to direct dependencies so that future patch and minor versions are allowed. This enables projects to better maintain and deduplicate their own transitive dependencies while not requiring direct updates to lint-staged. This was changed in 16.2.0 after the vulnerability issues withchalkanddebug, which were also removed in the same version.Given the recent vulnerabilities in the npm ecosystem, it's best to be very careful when updating dependencies.
v16.2.0Compare Source
Minor Changes
#1615
99eb742Thanks @iiroj! - Added a new option--fail-on-changesto make lint-staged exit with code 1 when tasks modify any files, making theprecommithook fail. This is similar to thegit diff --exit-codeoption. Using this flag also implies the--no-revertflag which means any changes made by tasks will be left in the working tree after failing, so that they can be manually staged and the commit tried again.#1611
cd05fd3Thanks @rlorenzo! - Added a new option--continue-on-errorso that lint-staged will run all tasks to completion even if some of them fail. By default, lint-staded will exit early on the first failure.#1637
82fcc07Thanks @iiroj! - Internal lint-staged errors are now thrown and visible in the console output. Previously they were caught with the process exit code set to 1, but not logged. This happens when, for example, there's a syntax error in the lint-staged configuration file.#1647
a5ecc06Thanks @iiroj! - Remove debug as a dependency due to recent malware issue; read more at debug-js/debug#1005. Because of this, theDEBUGenvironment variable is no longer supported — use the--debugto enable debugging#1636
8db2717Thanks @iiroj! - Added a new option--hide-unstagedso that lint-staged will hide all unstaged changes to tracked files before running tasks. The changes will be applied back after running the tasks. Note that the combination of flags--hide-unstaged --no-hide-partially-stagedisn't meaningful and behaves the same as just--hide-unstaged.Thanks to @ItsNickBarry for the idea and initial implementation in #1552.
#1648
7900b3bThanks @iiroj! - Remove lilconfig to reduce reliance on third-party dependencies. It was used to find possible config files outside of those tracked in Git, including from the parent directories. This behavior has been moved directly into lint-staged and should work about the same.Patch Changes
#1633
7f9e485Thanks @dependabot! - Bumps listr2 from 9.0.3 to 9.0.4.#1626
99d5a9bThanks @iiroj! - Due to recent phishing attacks, for example [email protected] was released with malware. To avoid lint-staged's users being at risk the direct dependencies are pinned to exact versions, instead of allowing future patch versions with the caret (^) range.#1588
035bbf2Thanks @outslept! - Increase performance by listing staged files and searching for configuration concurrently.#1645
deba3adThanks @iiroj! - Remove chalk as a dependency due to recent malware issue; read more at chalk/chalk#656.If you are having trouble with ANSI color codes when using lint-staged, you can try setting either
FORCE_COLOR=trueorNO_COLOR=trueenv variables.v16.1.6Compare Source
Patch Changes
e93578eThanks @iiroj! - Try to improve terminating of subprocess of tasks by usingSIGKILL, and only callingpidtreewhen the the main task process has a known pid.v16.1.5Compare Source
Patch Changes
4e3ce22Thanks @srsatt! - Detect the git repo's top-level directory correctly when in a worktree.v16.1.4Compare Source
Patch Changes
90b37b0Thanks @iiroj! - Add anothertypesfield topackage.jsonto make even more sure NPM detects that lint-staged includes built-in TypeScript type definitions.v16.1.3Compare Source
Patch Changes
7ea700bThanks @dword-design! - Add thetypesfield topackage.jsonto make sure NPM detects lint-staged includes built-in TypeScript type definitions.Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.