fix: improve advanced settings UI and make update_todo_list references conditional #7810
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the feedback from issue #5624 by fixing two specific issues:
Changes Made
1. Fixed Advanced Settings UI Issues
gap-2class) between chevron and text, removed margin from chevron (mr-1→ removed)webview-ui/src/components/chat/CodeIndexPopover.tsx2. Made update_todo_list References Conditional
update_todo_listtool in prompts were hardcoded regardless of feature being enabledtodoListEnabledsettingsrc/core/environment/reminder.ts- AddedtodoListEnabledparameter and conditional logicsrc/core/environment/getEnvironmentDetails.ts- Updated function call to passtodoListEnabledparameterpackages/types/src/mode.ts- Updated architect mode instructions to conditionally reference the toolTesting
Review
This PR attempts to address Issue #5624. Feedback and guidance are welcome!
Important
Improves advanced settings UI in
CodeIndexPopover.tsxand makesupdate_todo_listreferences conditional based ontodoListEnabled.CodeIndexPopover.tsxby addinggap-2class and removingmr-1from chevron.update_todo_listreferences conditional based ontodoListEnabledinreminder.tsandgetEnvironmentDetails.ts.formatReminderSection()inreminder.tsto handle disabled todo list state.getEnvironmentDetails()ingetEnvironmentDetails.tsto passtodoListEnabledparameter.mode.tsto conditionally referenceupdate_todo_list.This description was created by
for 1b1af5a. You can customize this summary. It will automatically update as commits are pushed.