-
Notifications
You must be signed in to change notification settings - Fork 2.5k
feat: implement Roomote Control feature page #7845
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Add complete Roomote Control landing page with all sections - Implement hero section with video embed - Create narrative band with 3-card layout - Add 5-step 'How it works' section with visual flow - Build 3x3 feature grid with updated icons - Add testimonials section with avatar images - Implement comprehensive FAQ with documentation links - Create final CTA section matching site design - Add responsive design and animations throughout - Include SEO metadata and OpenGraph tags
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for implementing the Roomote Control feature page! The overall structure and design look great. I've reviewed the changes and found some issues that need attention, particularly around the placeholder images and the known avatar display issues you mentioned. I've left specific suggestions inline to help improve the implementation.
| @@ -0,0 +1 @@ | |||
| placeholder No newline at end of file | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This appears to be a placeholder text file instead of an actual image. This will cause broken images in production. Could you please add the actual avatar images or use proper placeholder images?
Also, regarding your help request about avatars not displaying crisp in dark mode - this might be related to the image format or resolution. Consider using higher resolution images (2x for retina displays) and ensuring proper image optimization.
| @@ -0,0 +1 @@ | |||
| placeholder No newline at end of file | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same issue here - this is a text placeholder instead of an actual image file. Please add the real image asset.
| } from "react-icons/fa6" | ||
| import { Bot, Code2, Brain, Globe, Terminal, Puzzle } from "lucide-react" | ||
|
|
||
| export default function IconTestPage() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this test page intended for production? It appears to be a development utility for comparing icon libraries. Consider either:
- Moving it to a development-only route
- Adding authentication/environment checks
- Removing it before merging
If it's meant for internal use, you might want to protect it behind authentication.
| <div className="h-8 w-8 rounded-full bg-muted-foreground/10" /> | ||
| </div> | ||
| )} | ||
| <Image |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good error handling for failed image loads! However, to address the flashing issue you mentioned, consider adding quality, placeholder blur, and a blurDataURL to help with the visual issues. The Next.js Image component supports these props for smoother loading.
| ease: [0.21, 0.45, 0.27, 0.9], | ||
| }}> | ||
| <div className="group relative rounded-lg border border-border/50 bg-background/30 backdrop-blur-xl transition-all duration-300 hover:border-border"> | ||
| <button |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we improve accessibility here? The accordion needs better ARIA attributes. Consider adding aria-controls and id attributes to properly link the button and content elements for screen readers.
| Early Access | ||
| </span> | ||
| {/* Glint effect */} | ||
| <div className="absolute inset-0 -translate-x-full animate-[shimmer_2s_infinite] bg-gradient-to-r from-transparent via-white/20 to-transparent" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The infinite shimmer animation could impact battery life on mobile devices. Consider limiting iterations with animate-[shimmer_2s_3] or using Intersection Observer to pause when not in viewport. Or better yet, only animate on hover/focus for better performance.
| </Button> | ||
| <Button size="lg" variant="outline" asChild className="group w-full sm:w-auto"> | ||
| <Link | ||
| href="https://youtube.com/shorts/2T2CA6CYxlI" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For consistency, external links should use the same pattern throughout. Since this is an external YouTube link, it's correct to use an anchor tag, but consider creating a reusable ExternalLink component for consistency across the codebase.
| {index < steps.length - 1 && ( | ||
| <div className="absolute -right-5 top-1/2 hidden -translate-y-1/2 lg:block"> | ||
| <motion.div | ||
| animate={{ x: [0, 6, 0] }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice implementation of the step-by-step flow! Consider adding prefers-reduced-motion media query support to respect user preferences for the animation.
screencapture-localhost-3000-roomote-control-2025-09-10-11_30_25.pdf
Copy status
All visible copy is from the shared draft doc for alignment: https://www.notion.so/roo-code/Feature-Roomote-Control-25cfd1401b0a80afaeb5de1616ed3b44
Help requested
Implementation notes
SEO / Social
QA checklist
Risk / rollout
Notes for reviewers