fix: update Z.AI endpoint to use improved coding API #7896
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Changed international Z.AI endpoint from /api/paas/v4 to /api/coding/paas/v4 - Updated corresponding tests to reflect the new endpoint - This improves tool-calling capabilities for GLM models as documented by Z.AI Fixes #7895
dosubot
bot
added
size:S
![roomote[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
| ...options, | ||
| providerName: "Z AI", | ||
| baseURL: isChina ? "https://open.bigmodel.cn/api/paas/v4" : "https://api.z.ai/api/paas/v4", | ||
| baseURL: isChina ? "https://open.bigmodel.cn/api/paas/v4" : "https://api.z.ai/api/coding/paas/v4", |
Contributor
Author
There was a problem hiding this comment.
Consider adding a comment here explaining why the international endpoint uses path while China doesn't. This would help future maintainers understand the reasoning behind this difference:
| new ZAiHandler({ zaiApiKey: "test-zai-api-key", zaiApiLine: "international" }) | ||
| expect(OpenAI).toHaveBeenCalledWith(expect.objectContaining({ baseURL: "https://api.z.ai/api/paas/v4" })) | ||
| expect(OpenAI).toHaveBeenCalledWith( | ||
| expect.objectContaining({ baseURL: "https://api.z.ai/api/coding/paas/v4" }), |
Contributor
Author
There was a problem hiding this comment.
While the unit tests correctly verify the endpoint URLs, would it be valuable to add integration tests that verify the improved tool-calling capabilities mentioned in issue #7895? This could help ensure the new endpoint actually delivers the expected improvements.
hannesrudolph
added
the
Issue/PR - Triage
dmarkey
approved these changes
Sep 11, 2025
hannesrudolph
added
PR - Needs Preliminary Review
and removed
Issue/PR - Triage
Member
|
We got in contact with the Z.AI team, I'll be opening a new PR soon. |
github-project-automation
bot
moved this from PR [Needs Prelim Review]
to Done
in Roo Code Roadmap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR attempts to address Issue #7895 by updating the Z.AI international endpoint to use the improved coding-specific API endpoint.
Changes
https://api.z.ai/api/paas/v4tohttps://api.z.ai/api/coding/paas/v4Motivation
As reported in #7895, the normal endpoint produces poor results in Roo-Code, particularly with tool-calling capabilities. The new endpoint (
https://api.z.ai/api/coding/paas/v4) is explicitly documented by Z.AI for Roo integration and provides better tool-calling support for GLM models.Testing
References
Feedback and guidance are welcome!
Important
Update international Z.AI endpoint to
https://api.z.ai/api/coding/paas/v4inzai.tsand adjust tests inzai.spec.tsaccordingly.zai.tsfromhttps://api.z.ai/api/paas/v4tohttps://api.z.ai/api/coding/paas/v4.https://open.bigmodel.cn/api/paas/v4.zai.spec.tsto expect the new international endpoint.This description was created by
for 088f721. You can customize this summary. It will automatically update as commits are pushed.