-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Improve mode names UI consistency #7929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
MeetSohailCodes
wants to merge
9
commits into
RooCodeInc:main
from
MeetSohailCodes:improve-mode-names-ui-consistency
Closed
Changes from 8 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
3f6e5d7
feat: improve mode names and UI consistency
MeetSohailCodes b95c002
fix: resolve merge conflict in ModeSelector; use scroll container and…
MeetSohailCodes b770c53
Update webview-ui/src/i18n/locales/en/chat.json
MeetSohailCodes 476aa67
feat(ui,i18n): add fileOperations editing/reading labels and fix miss…
MeetSohailCodes 230a72c
test(webview): add minimal tests for FileIcon and FilePathWithIcon; c…
MeetSohailCodes 505f928
ci: update pnpm-lock.yaml after dep changes (vscode-material-icons ^0…
MeetSohailCodes 30b0d72
fix(i18n): move Hindi editing/reading labels under fileOperations; pa…
MeetSohailCodes 21d40c3
test-fix(webview/core): restore expected texts and classes for tests
MeetSohailCodes ef8f28a
Update CHANGELOG.md
MeetSohailCodes File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -190,7 +190,7 @@ export function ContactForm({ formType, buttonText, buttonClassName }: ContactFo | |
| id="name" | ||
| name="name" | ||
| type="text" | ||
| className={`w-full rounded-md border ${ | ||
| className={`w-full rounded-2xl border ${ | ||
| formErrors.name ? "border-red-500" : "border-input" | ||
| } bg-background px-3 py-2 text-sm focus:outline-none focus:ring-2 focus:ring-ring`} | ||
| placeholder="Your name" | ||
|
|
@@ -206,7 +206,7 @@ export function ContactForm({ formType, buttonText, buttonClassName }: ContactFo | |
| id="company" | ||
| name="company" | ||
| type="text" | ||
| className={`w-full rounded-md border ${ | ||
| className={`w-full rounded-2xl border ${ | ||
| formErrors.company ? "border-red-500" : "border-input" | ||
| } bg-background px-3 py-2 text-sm focus:outline-none focus:ring-2 focus:ring-ring`} | ||
| placeholder="Your company" | ||
|
|
@@ -222,7 +222,7 @@ export function ContactForm({ formType, buttonText, buttonClassName }: ContactFo | |
| id="email" | ||
| name="email" | ||
| type="email" | ||
| className={`w-full rounded-md border ${ | ||
| className={`w-full rounded-2xl border ${ | ||
| formErrors.email ? "border-red-500" : "border-input" | ||
| } bg-background px-3 py-2 text-sm focus:outline-none focus:ring-2 focus:ring-ring`} | ||
| placeholder="[email protected]" | ||
|
|
@@ -238,7 +238,7 @@ export function ContactForm({ formType, buttonText, buttonClassName }: ContactFo | |
| id="website" | ||
| name="website" | ||
| type="url" | ||
| className={`w-full rounded-md border ${ | ||
| className={`w-full rounded-2xl border ${ | ||
| formErrors.website ? "border-red-500" : "border-input" | ||
| } bg-background px-3 py-2 text-sm focus:outline-none focus:ring-2 focus:ring-ring`} | ||
| placeholder="https://example.com" | ||
|
|
@@ -253,7 +253,7 @@ export function ContactForm({ formType, buttonText, buttonClassName }: ContactFo | |
| <select | ||
| id="engineerCount" | ||
| name="engineerCount" | ||
| className={`w-full rounded-md border ${ | ||
| className={`w-full rounded-2xl border ${ | ||
| formErrors.engineerCount ? "border-red-500" : "border-input" | ||
| } bg-background px-3 py-2 text-sm focus:outline-none focus:ring-2 focus:ring-ring`} | ||
| defaultValue="1-10"> | ||
|
|
@@ -270,7 +270,7 @@ export function ContactForm({ formType, buttonText, buttonClassName }: ContactFo | |
| </div> | ||
|
|
||
| {submitStatus === "error" && ( | ||
| <div className="rounded-md bg-red-50 p-3 text-sm text-red-500 dark:bg-red-900/20"> | ||
| <div className="rounded-2xl bg-red-50 p-3 text-sm text-red-500 dark:bg-red-900/20"> | ||
| There was an error submitting your request. Please try again later. | ||
| </div> | ||
| )} | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.