Skip to content

fix: prevent context compression trigger when saving unchanged settings #7947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

fix: prevent context compression trigger when saving unchanged settings #7947

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
83ed754
fix: prevent context compression trigger when saving unchanged settings
roomote Sep 12, 2025
3df1150
fix: prevent unnecessary state updates when settings haven't changed
roomote Sep 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 16 additions & 6 deletions src/core/webview/webviewMessageHandler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -580,14 +580,24 @@ export const webviewMessageHandler = async (
case "askResponse":
provider.getCurrentTask()?.handleWebviewAskResponse(message.askResponse!, message.text, message.images)
break
case "autoCondenseContext":
await updateGlobalState("autoCondenseContext", message.bool)
await provider.postStateToWebview()
case "autoCondenseContext": {
const currentValue = getGlobalState("autoCondenseContext")
// Only update if the value has actually changed
if (currentValue !== message.bool) {
await updateGlobalState("autoCondenseContext", message.bool)
await provider.postStateToWebview()
}
break
case "autoCondenseContextPercent":
await updateGlobalState("autoCondenseContextPercent", message.value)
await provider.postStateToWebview()
}
case "autoCondenseContextPercent": {
const currentValue = getGlobalState("autoCondenseContextPercent")
// Only update if the value has actually changed
if (currentValue !== message.value) {
await updateGlobalState("autoCondenseContextPercent", message.value)
await provider.postStateToWebview()
}
break
}
case "terminalOperation":
if (message.terminalOperation) {
provider.getCurrentTask()?.handleTerminalOperation(message.terminalOperation)
Expand Down
5 changes: 4 additions & 1 deletion webview-ui/src/components/settings/SettingsView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -328,7 +328,10 @@ const SettingsView = forwardRef<SettingsViewRef, SettingsViewProps>(({ onDone, t
vscode.postMessage({ type: "writeDelayMs", value: writeDelayMs })
vscode.postMessage({ type: "screenshotQuality", value: screenshotQuality ?? 75 })
vscode.postMessage({ type: "terminalOutputLineLimit", value: terminalOutputLineLimit ?? 500 })
vscode.postMessage({ type: "terminalOutputCharacterLimit", value: terminalOutputCharacterLimit ?? 50000 })
vscode.postMessage({
type: "terminalOutputCharacterLimit",
value: terminalOutputCharacterLimit ?? 50000,
})
vscode.postMessage({ type: "terminalShellIntegrationTimeout", value: terminalShellIntegrationTimeout })
vscode.postMessage({ type: "terminalShellIntegrationDisabled", bool: terminalShellIntegrationDisabled })
vscode.postMessage({ type: "terminalCommandDelay", value: terminalCommandDelay })
Expand Down
Loading