fix: respect autoCondenseContext setting on context window overflow #7957
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update Task.handleContextWindowExceededError() to read user settings from state - No longer force autoCondenseContext=true when context window is exceeded - Use user's configured autoCondenseContextPercent instead of FORCED_CONTEXT_REDUCTION_PERCENT - Add comprehensive tests for the new behavior Fixes #7953
dosubot
bot
added
size:L
![roomote[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
| private async handleContextWindowExceededError(): Promise<void> { | ||
| const state = await this.providerRef.deref()?.getState() | ||
| const { profileThresholds = {} } = state ?? {} | ||
| const { profileThresholds = {}, autoCondenseContext = true, autoCondenseContextPercent = 100 } = state ?? {} |
Contributor
Author
There was a problem hiding this comment.
Nice fix! The implementation correctly addresses the issue by reading autoCondenseContext and autoCondenseContextPercent from state instead of forcing them.
| `[Task#${this.taskId}] Context window exceeded for model ${this.api.getModel().id}. ` + | ||
| `Current tokens: ${contextTokens}, Context window: ${contextWindow}. ` + | ||
| `Forcing truncation to ${FORCED_CONTEXT_REDUCTION_PERCENT}% of current context.`, | ||
| `Auto-condense: ${autoCondenseContext}, Threshold: ${autoCondenseContextPercent}%.`, |
Contributor
Author
There was a problem hiding this comment.
Good update to the log message - it now accurately reflects what's happening instead of claiming to force truncation.
| @@ -0,0 +1,389 @@ | |||
| // npx vitest src/core/task/__tests__/Task.handleContextWindowExceeded.spec.ts | |||
Contributor
Author
There was a problem hiding this comment.
Excellent test coverage! The tests comprehensively verify the new behavior with different scenarios including disabled auto-condense, enabled auto-condense, undefined state, and edge cases.
hannesrudolph
added
the
Issue/PR - Triage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the issue where context condensing was triggered even when the auto-condense setting was disabled. The problem occurred specifically in the overflow handler path when the context window was exceeded.
Problem
As detailed by @hannesrudolph in #7953:
Task.handleContextWindowExceededError()was forcing summarization regardless of user settingsautoCondenseContext: trueand usingFORCED_CONTEXT_REDUCTION_PERCENT(75%)Solution
Task.handleContextWindowExceededError()to respect the user'sautoCondenseContextandautoCondenseContextPercentsettings from stateChanges
src/core/task/Task.ts
handleContextWindowExceededError()to readautoCondenseContextandautoCondenseContextPercentfrom statesrc/core/task/tests/Task.handleContextWindowExceeded.spec.ts
Testing
Impact
This change ensures that users who have disabled auto-condensing will no longer see unexpected summarization when their context window is exceeded. The system will respect their preference and use simple truncation instead.
Fixes #7953
Important
Fixes
Task.handleContextWindowExceededError()to respect user settings for auto-condensing, with tests verifying the behavior.Task.handleContextWindowExceededError()now respectsautoCondenseContextandautoCondenseContextPercentsettings from state.Task.handleContextWindowExceeded.spec.tsto verify behavior with differentautoCondenseContextsettings.Task.tsto reflect actual settings used.This description was created by
for 8fbc6d7. You can customize this summary. It will automatically update as commits are pushed.