fix: Makes RooTips appear in home again

[brunobergher]

But because this is dependent on knowing the state of a DismissibleUpsell, it adds some utilities to be able to access their state from the outside. No visual changes.

[roomote]

Thank you for your contribution! I've reviewed the changes and found some issues that need attention. The implementation adds useful utilities for accessing DismissibleUpsell state, but there are a few critical issues to address.

[roomote]

Is this intentional? The context starts with isLoading: true but components might render before the dismissed list is fetched. This could cause a flash of upsells that should be hidden.

Consider either:

1. Starting with isLoading: false and an empty list
2. Or ensuring components handle the loading state properly to prevent flashing

[brunobergher]

Let's switch to isLoading false by default

[roomote]

Could we consider lifting the DismissedUpsellsProvider to a higher level? Each DismissibleUpsell instance wrapping itself with a provider could cause issues if multiple upsells are rendered, as each would have its own provider instance and separate state.

The provider should ideally be at the app root level to share state across all upsells.

[brunobergher]

I did, but this isn't used often enough to warrant being at the top level. If other reviewers agree with you, I can make that change, but I'll refrain from it for now.

[roomote]

Minor: Import path inconsistency. Some imports use @/ alias while others use @src/. Consider standardizing on one approach for consistency.

[brunobergher]

@roomote-agent read through the comments and implement the relevant feedback.

[roomote]

Hi @brunobergher, I've reviewed the PR comments and I'm now implementing the requested changes. I'll address the following:

1. Change isLoading default to false in DismissedUpsellsContext.tsx
2. Fix import path inconsistency in ChatView.tsx

I'll update you once the changes are complete.

[roomote]

Hi @brunobergher,

I've successfully implemented the requested changes from the PR review:

✅ Changed isLoading default to false in DismissedUpsellsContext.tsx (line 26)

• This prevents the flash of upsells that should be hidden when the component first renders

✅ Fixed import path inconsistency in ChatView.tsx (line 62)

• Changed @/hooks/useUpsellVisibility to @src/hooks/useUpsellVisibility for consistency

The changes have been pushed to the PR branch. The relevant CI checks (compile, linting, code analysis) are passing. The test failures appear to be pre-existing issues unrelated to these changes.

Let me know if you need any additional adjustments!