-
Notifications
You must be signed in to change notification settings - Fork 2.6k
feat: enhance settings import functionality for remote workspaces #8060
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution! I've reviewed the changes and found several issues that need attention before this can be merged.
b504c7c to
a6cb450
Compare
- Add importSettingsFromContent function to import settings from string content - Refactor importSettingsFromPath to reuse import logic - Improve import error handling and type validation - Add ImportSource type to support file path or content - Update related components and message handling to support new import methods - Enhance test cases to cover new import functionality
a6cb450 to
c383c77
Compare
- Add importSettingsFromContent function to import settings from string content - Refactor importSettingsFromPath to reuse import logic - Improve import error handling and type validation - Add ImportSource type to support file path or content - Update related components and message handling to support new import methods - Enhance test cases to cover new import functionality
- Replace manual file input handling with pickFileAsText utility for importing settings from local JSON files. - Enhance error handling for file reading failures. - Streamline code for better readability and maintainability.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @jqknono I found a couple of things that could be improved, let me know what you think.
1fb186d to
9c68826
Compare
Hi, @daniel-lxs |
|
Hi, @daniel-lxs @mrubens |
|
Thanks for the contribution. While the implementation is well done, this feature isn't in our current plans. Copying the settings file is straightforward enough for remote setups. |
Related GitHub Issue
Closes: #7930
Roo Code Task Context (Optional)
Description
This improves user experience by providing flexibility in settings management across different environments.
Test Procedure
Scenario: Importing settings from a local file while connected via Remote-SSH
Given I am connected to a remote development host using the Remote-SSH extension in VSCode
And I have a valid Roo Code settings .json file on my local machine
When I open the "About Roo Code" view and click the "Import" button
Then a system file dialog opens, allowing me to browse the file system of my local machine
And I can select a local .json file to import
And upon selection, the settings are successfully applied to Roo Code on the remote host
Added Unittest cases:
Pre-Submission Checklist
Screenshots / Videos
Before:
After:
Documentation Updates
Additional Notes
Get in Touch
jqknono
Important
Enhances settings import for remote workspaces by adding local file import via webview file picker and updating import logic.
webviewMessageHandler.App.tsxfor selecting local JSON files.requestLocalSettingsFilemessage type inExtensionMessage.tsandWebviewMessage.ts.webviewMessageHandler.App.tsx.This description was created by
for b420d6b3c8dd7ffe7859aff0b7237057ce686bab. You can customize this summary. It will automatically update as commits are pushed.