feat: add global command to toggle Auto-Approve with keybinding #8073
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add new command "roo-cline.toggleAutoApprove" to package.json - Register command handler in registerCommands.ts to toggle autoApprovalEnabled state - Add default keybinding Ctrl+Shift+A (Cmd+Shift+A on Mac) - Update CommandId type definition to include new command - Add localization for command title Fixes #8072
dosubot
bot
added
size:M
hannesrudolph
added
the
Issue/PR - Triage
![roomote[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
| // Show notification to user | ||
| const statusText = newState ? "enabled" : "disabled" | ||
| vscode.window.showInformationMessage(`Auto-Approve ${statusText}`) | ||
| }, |
Contributor
Author
There was a problem hiding this comment.
Missing unit tests for the new toggleAutoApprove command. Would be good to add tests similar to the existing getVisibleProviderOrLog tests to verify:
- The toggle functionality works correctly
- The state is properly updated
- The webview receives the update
- The notification is shown
src/activate/registerCommands.ts
Outdated
|
|
||
| // Show notification to user | ||
| const statusText = newState ? "enabled" : "disabled" | ||
| vscode.window.showInformationMessage(`Auto-Approve ${statusText}`) |
Contributor
Author
There was a problem hiding this comment.
The notification message should be internationalized. Consider using:
This would require adding the corresponding keys to the localization files.
| "key": "ctrl+shift+a", | ||
| "mac": "cmd+shift+a", | ||
| "win": "ctrl+shift+a", | ||
| "linux": "ctrl+shift+a" |
Contributor
Author
There was a problem hiding this comment.
The keybinding Ctrl+Shift+A (Cmd+Shift+A on Mac) might conflict with other extensions or VS Code defaults. While this works, consider documenting this in the README or checking for potential conflicts with common extensions.
hannesrudolph
added
PR - Needs Preliminary Review
and removed
Issue/PR - Triage
- Replace hardcoded English status text with translated versions - Add status.enabled and status.disabled translations to all 18 language files - Update notification to use t() function for proper i18n support - Ensures Auto-Approve status displays in user's selected language Addresses PR #8073 review feedback
daniel-lxs
moved this from PR [Needs Prelim Review]
to PR [Needs Review]
in Roo Code Roadmap
daniel-lxs
approved these changes
Sep 19, 2025
Member
|
Closing in favor of #8214 |
github-project-automation
bot
moved this from PR [Needs Review]
to Done
in Roo Code Roadmap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a global command to toggle the Auto-Approve setting with keyboard shortcut support, addressing Issue #8072.
Changes
roo-cline.toggleAutoApproveto package.jsonTesting
Notes
The review identified two minor improvements that could be addressed in a follow-up:
These don't affect the core functionality and can be addressed separately if needed.
Fixes #8072
Important
Adds
toggleAutoApprovecommand with keybinding and notification, updates localization, and suggests future improvements.roo-cline.toggleAutoApprovecommand inpackage.jsonto toggleautoApprovalEnabledstate.Ctrl+Shift+A(Cmd+Shift+A on Mac) added inpackage.json.registerCommands.ts.toggleAutoApprovecommand notification incommon.jsonacross multiple languages.This description was created by
for 314feb0. You can customize this summary. It will automatically update as commits are pushed.