just update the deps and try to make the versions consistent #8080
Conversation
dosubot
bot
added
the
size:L
![roomote[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
| @@ -1 +1 @@ | |||
| v20.19.2 | |||
| v22.18.0 | |||
There was a problem hiding this comment.
Is using Node.js 22 (Current) intentional? Node.js 22 is not an LTS version. For production applications, it's typically recommended to use LTS versions for stability. Node.js 20 is the current LTS and will be supported until April 2026. Could we consider sticking with Node.js 20 LTS instead?
| "default-shell": "^2.2.0", | ||
| "delay": "^6.0.0", | ||
| "diff": "^5.2.0", | ||
| "diff": "^8.0.2", |
There was a problem hiding this comment.
The update from diff@^5.2.0 to diff@^8.0.2 is a significant jump (3 major versions). Have you verified that this doesn't introduce any breaking changes in how diffs are generated or processed in the codebase?
There was a problem hiding this comment.
I dunno, but I've been using the build without issues.
| "@mistralai/mistralai": "^1.9.18", | ||
| "@modelcontextprotocol/sdk": "1.12.0", | ||
| "@qdrant/js-client-rest": "^1.14.0", | ||
| "@anthropic-ai/bedrock-sdk": "^0.24.0", |
There was a problem hiding this comment.
These AI SDK updates are quite significant:
@anthropic-ai/bedrock-sdk: ^0.10.2 → ^0.24.0@anthropic-ai/vertex-sdk: ^0.7.0 → ^0.13.2@google/genai: ^1.0.0 → ^1.20.0
Have you tested that these updates don't break any existing AI provider integrations? Major version bumps often include API changes.
There was a problem hiding this comment.
Been using the build on my machine for the past few months. If someone depends on some legacy functionality, there's high possibility that the AI providers have already dropped the support anyway. I.e., the risk of continuing to use old SDK version is higher than upgrading the version, in my opinion.
| "turndown": "^7.2.0", | ||
| "uuid": "^11.1.0", | ||
| "turndown": "^7.2.1", | ||
| "uuid": "^13.0.0", |
There was a problem hiding this comment.
The uuid package jumped from ^11.1.0 to ^13.0.0 (2 major versions). Could you confirm this doesn't introduce any breaking changes in UUID generation or validation?
There was a problem hiding this comment.
Haven't bumped into issues.
| "sourceMap": true, | ||
| "strict": true, | ||
| "target": "ES2022", | ||
| "target": "esnext", |
There was a problem hiding this comment.
Changing the compilation target from "ES2022" to "esnext" enables the latest JavaScript features but might affect compatibility with older environments. Is this change necessary for the dependency updates, or could we keep "ES2022" for better compatibility?
There was a problem hiding this comment.
You sound like AI; backward compatibility in vscode extensions is like totally irrelevant. Who would keep vscode not updated?
| "@types/qrcode": "^1.5.5", | ||
| "@vscode/codicons": "^0.0.36", | ||
| "@vscode/codicons": "^0.0.40", | ||
| "@vscode/webview-ui-toolkit": "^1.4.0", |
There was a problem hiding this comment.
Good point about @vscode/webview-ui-toolkit being deprecated! While this PR doesn't address it, should we create a follow-up issue to track its removal and migration to an alternative solution?
There was a problem hiding this comment.
This is not an easy thing to solve, so I don't really have opinion. I hope someone with more knowledge could address the issue.
hannesrudolph
added
the
Issue/PR - Triage
|
We would prefer to use the PRs created by our bot that give us details about the new versions. We appreciate the interest and your contribution. |
3 participants
Not a serious PR, but just trying to keep versions up-to-date and consistent (e.g. consistently use the actual node.js version in current vscode). Been running custom build without apparent issues for the past months, so probably it's ok to just update the deps? Particularly, the AI sdk deps should probably be updated?, e.g.:
"@anthropic-ai/bedrock-sdk": "^0.10.2" => "^0.24.0"
"@anthropic-ai/vertex-sdk": "^0.7.0" => "^0.13.2"
"@google/genai": "^1.0.0" =>"^1.20.0"
"@lmstudio/sdk": "^1.1.1" => "^1.5.0"
, etc.
Also, is there active effort for getting rid of @vscode/webview-ui-toolkit? This is like seriously deprecated dependency that should not be used anymore.
Important
Update Node.js and various dependencies across multiple
package.jsonfiles to ensure consistency and use the latest versions.v22.18.0in.nvmrcandpackage.jsonfiles.src/package.json:@anthropic-ai/bedrock-sdkto^0.24.0@anthropic-ai/vertex-sdkto^0.13.2@google/genaito^1.20.0@lmstudio/sdkto^1.5.0apps/vscode-e2e/package.json,apps/web-evals/package.json, andwebview-ui/package.jsonto latest versions.@types/nodeto22.18.0in multiplepackage.jsonfiles.typescriptto^5.9.2inapps/vscode-e2e/package.jsonandwebview-ui/package.json.vitestto^3.2.4in severalpackage.jsonfiles.pnpmversion to10.16.1inpackage.json.This description was created by
for b9dfbab. You can customize this summary. It will automatically update as commits are pushed.