Skip to content

Conversation

@hannesrudolph
Copy link
Collaborator

@hannesrudolph hannesrudolph commented Sep 17, 2025

Relates to #8005

Rewrite workflow to bump README cacheBust and open PR only when changed; add explicit permissions and simplify steps.


Important

Updates GitHub Actions workflow to refresh contrib.rocks cache by modifying cacheBust in README files and creating a PR only if changes occur.

  • Workflow Changes:
    • Renames job to refresh-contrib-cache in update-contributors.yml.
    • Adds explicit permissions for contents and pull-requests.
    • Simplifies steps by removing Node.js setup and Husky disablement.
  • Behavior:
    • Updates cacheBust parameter in README.md and locales/*/README.md.
    • Creates a pull request only if changes are detected in README files.
  • Misc:
    • Changes branch name to refresh-contrib-cache for pull requests.
    • Updates commit message and pull request title to reflect cache refresh.

This description was created by Ellipsis for be7e765. You can customize this summary. It will automatically update as commits are pushed.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR rewrites the GitHub workflow from updating contributors to refreshing contrib.rocks image cache by bumping the cacheBust parameter. It simplifies the workflow by removing Node.js setup and contributor update logic, and moves permissions to the workflow level.

  • Removes push trigger and contributor update functionality
  • Adds explicit workflow-level permissions for contents and pull-requests
  • Replaces complex contributor update with simple timestamp-based cacheBust parameter update

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Sep 17, 2025
Copy link
Contributor

@roomote roomote bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! I've reviewed the changes and found critical issues that need attention before this workflow can function properly.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this intentional? The workflow filename is still update-contributors.yml but its purpose has completely changed to refreshing contrib.rocks cache. Should we rename this file to something like refresh-contrib-cache.yml to better reflect its new purpose?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor style suggestion: The inline comment after the workflow name is unconventional. Consider either removing it or moving it to a separate comment line:

Suggested change
name: Update Contributors # Refresh contrib.rocks image cache
name: Refresh Contrib.rocks Cache
# Refreshes the contrib.rocks image cache by updating cacheBust parameter

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Critical Issue: This workflow will fail because the cacheBust parameter doesn't exist in README.md. I checked the current README.md and there's no cacheBust= parameter to update. The workflow will exit with code 1 and the error message "cacheBust parameter not found in README.md".

Additionally, the README.md doesn't contain any contrib.rocks image or reference. Before this workflow can work, we need to:

  1. Add a contrib.rocks image to the README.md
  2. Include the cacheBust parameter in the image URL

Example:

![Contributors](https://contrib.rocks/image?repo=RooCodeInc/Roo-Code&cacheBust=1234567890)

@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Sep 17, 2025
Rewrite workflow to bump README cacheBust and open PR only when changed; add explicit permissions and simplify steps.
@hannesrudolph hannesrudolph force-pushed the ci/refresh-contrib-cache-workflow branch from 3336351 to 634602f Compare September 17, 2025 20:33
Bump cacheBust in README.md and locales/*/README.md; PR auto-created only when changes detected.
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 17, 2025
@daniel-lxs daniel-lxs moved this from Triage to PR [Needs Review] in Roo Code Roadmap Sep 17, 2025
@hannesrudolph hannesrudolph added PR - Needs Review and removed Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. labels Sep 17, 2025
@mrubens mrubens merged commit c943ba7 into main Sep 29, 2025
12 checks passed
@mrubens mrubens deleted the ci/refresh-contrib-cache-workflow branch September 29, 2025 17:17
@github-project-automation github-project-automation bot moved this from PR [Needs Review] to Done in Roo Code Roadmap Sep 29, 2025
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Sep 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer PR - Needs Review size:M This PR changes 30-99 lines, ignoring generated files.