ctrl/cmd+click to navigate to files from textarea Closes #8144

[j-east]

Related GitHub Issue

@daniel-lxs
Closes #8144

Roo Code Task Context (Optional)

Description

functionality to focus on a file similar to ctrl+click in the debug window which will allow you to look at the files you add to context using @ . Goal is to make it easier to confirm context is useful before sending and also as a way to view specific methods or logic that you want Roo Code to focus on in the prompt.

Test Procedure

add context using @ and then ctrl/cmd+click to view the file in the editor.

Pre-Submission Checklist

• Issue Linked: This PR is linked to an approved GitHub Issue (see "Related GitHub Issue" above).
• Scope: My changes are focused on the linked issue (one major feature/fix per PR).
• [ X] Self-Review: I have performed a thorough self-review of my code.
• [ X] Testing: New and/or updated tests have been added to cover my changes (if applicable).
• Documentation Impact: I have considered if my changes require documentation updates (see "Documentation Updates" section below).
• [ X] Contribution Guidelines: I have read and agree to the Contributor Guidelines.

Screenshots / Videos

2025-09-17.17-01-44.1.mov

Documentation Updates

Additional Notes

Get in Touch

@jevons

---

Important

Adds feature to ChatTextArea for focusing on file mentions with @ and Ctrl/Cmd+Click, including event handling and styling updates.

• Behavior:
  • Adds functionality to ChatTextArea to focus on file mentions using @ and Ctrl/Cmd+Click.
  • Detects modifier key (Cmd on Mac, Ctrl on others) to enable clickable mentions.
  • Sends message to VSCode to open mentioned file.
• Event Handling:
  • Adds global keydown and keyup listeners in ChatTextArea.tsx to track modifier key state.
  • Adds click event listener to highlight layer for mention clicks.
• Styling:
  • Updates .mention-context-textarea-highlight in index.css to support hover and clickable states.
  • Adds transition and pointer events for clickable mentions.

^{This description was created by for d1fca3b. You can customize this summary. It will automatically update as commits are pushed.}

[ellipsis-dev]

Consider extracting the tooltip texts ('Cmd + Click to open' and 'Hold Cmd + Click to open') into translation keys using the translation function (t). Hardcoding these user‐facing texts may affect localization consistency.

^{This comment was generated because it violated a code review rule: irule_C0ez7Rji6ANcGkkX.}

[roomote]

Thank you for your contribution! I've reviewed the changes for adding Ctrl/Cmd+Click functionality to focus on file mentions. The feature works as described, but I found several issues that should be addressed:

Critical Issues (Must Fix):

1. Memory leak risk in ChatTextArea.tsx (lines 229-256): The global event listeners for keydown/keyup are added in a useEffect that depends on [handleGlobalKeyDown, handleGlobalKeyUp]. These callbacks are recreated on every render due to their dependency on isMac, potentially causing multiple listeners to be attached. Consider using stable references with useRef or memoizing more effectively.

Important Suggestions (Should Consider):

2. Duplicate CSS rules in index.css: The .mention-context-textarea-highlight class is defined twice - first at lines 382-387 (in the original file) and again at lines 433-456. The first definition should be removed to avoid confusion.

3. Missing accessibility support: The feature only works with mouse clicks. Consider adding keyboard support (e.g., Enter key when focused with modifier) for better accessibility.

4. Performance concern (line 810): The updateHighlights function is called on every input change and scroll event. For large text inputs, this could impact performance. Consider debouncing the updates.

Minor Improvements (Nice to Have):

5. Inconsistent event handling: The click handler is added to the highlight layer div but only processes clicks on MARK elements. Consider using event delegation more efficiently.

6. Incomplete command support (line 268): Commands are highlighted with the clickable class but the click handler only extracts the mention text without the leading slash. For commands, you might want to preserve the slash.

7. Missing visual feedback: When hovering with the modifier key pressed, users might benefit from additional visual cues beyond just the cursor change.

Overall, this is a useful feature that enhances the user experience. With these issues addressed, it will be a solid addition to the codebase.

[daniel-lxs]

Hey @captjevans Thank you for the contribution, it seems like there are some failing unit tests, can you take a look?