-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Added Codex provider support #8135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Codex provider support #8135
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution! I've reviewed the Codex CLI provider implementation and found some issues that need attention, particularly with test file imports and error handling. The overall architecture looks solid, but there are opportunities to improve code clarity and maintainability.
Co-authored-by: roomote[bot] <219738659+roomote[bot]@users.noreply.github.com>
Co-authored-by: roomote[bot] <219738659+roomote[bot]@users.noreply.github.com>
Co-authored-by: roomote[bot] <219738659+roomote[bot]@users.noreply.github.com>
Co-authored-by: roomote[bot] <219738659+roomote[bot]@users.noreply.github.com>
Co-authored-by: roomote[bot] <219738659+roomote[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces comprehensive Codex provider support through a CLI-backed implementation with persistent sessions, duplicate response filtering, and reasoning effort controls. The integration includes extensive UI components for provider configuration and authentication management.
- Adds complete Codex provider with CLI session management and response deduplication
- Integrates Codex throughout the settings UI with dynamic model discovery and authentication helpers
- Updates type definitions and configuration schemas to support Codex provider settings
Reviewed Changes
Copilot reviewed 20 out of 21 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| webview-ui/src/components/ui/hooks/useSelectedModel.ts | Adds Codex model selection support |
| webview-ui/src/components/settings/providers/index.ts | Exports new Codex provider component |
| webview-ui/src/components/settings/providers/OpenAICompatible.tsx | Adds override props for model configuration |
| webview-ui/src/components/settings/providers/Codex.tsx | Complete Codex provider UI with CLI management |
| webview-ui/src/components/settings/constants.ts | Adds Codex to provider constants |
| webview-ui/src/components/settings/ApiOptions.tsx | Integrates Codex provider in settings UI |
| src/shared/checkExistApiConfig.ts | Includes Codex in providers not requiring API keys |
| src/shared/tests/checkExistApiConfig.spec.ts | Adds test for Codex provider configuration |
| src/shared/WebviewMessage.ts | Adds Codex-specific message types |
| src/shared/ExtensionMessage.ts | Adds Codex model and status message types |
| src/integrations/codex/run.ts | Core Codex CLI integration with session management |
| src/core/webview/webviewMessageHandler.ts | Handles Codex CLI status and model discovery |
| src/api/providers/index.ts | Exports CodexHandler |
| src/api/providers/codex.ts | Main Codex provider implementation |
| src/api/providers/tests/codex.spec.ts | Unit tests for Codex provider |
| src/api/index.ts | Registers Codex provider in API factory |
| packages/types/src/providers/openai.ts | Adds gpt-5-codex model definition |
| packages/types/src/providers/index.ts | Exports Codex provider types |
| packages/types/src/providers/codex.ts | Complete Codex type definitions and model presets |
| packages/types/src/provider-settings.ts | Adds Codex provider schema and configuration |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
@Buzzwavemed thank you very much for helping with this! Unfortunately this implementation not send direct calls to the endpoint and instead uses a CLI layer which results in a pretty slow experience. Closing this in favour of another potential solution which goes about this aspect differently. Sorry about that. I really do appreciate your time on this. |
This pull request addresses issue #8049
Summary
Testing
Important
Add support for Codex provider with CLI-backed sessions, UI integration, and model management.
src/api/providers/codex.ts.src/api/index.tsandwebview-ui/src/components/settings/ApiOptions.tsx.src/integrations/codex/run.ts.codexModelstopackages/types/src/provider-settings.tsandwebview-ui/src/components/settings/constants.ts.packages/types/src/providers/codex.ts.webview-ui/src/components/settings/providers/Codex.tsx.webview-ui/src/components/settings/ApiOptions.tsxto include Codex in provider selection.src/api/providers/__tests__/codex.spec.ts.checkExistApiConfig.tsto recognize Codex as a provider that doesn't require additional keys.This description was created by
for 032b86b. You can customize this summary. It will automatically update as commits are pushed.