Skip to content

fix: align ContextMenu position in message edit mode #8191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix: align ContextMenu position in message edit mode #8191

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions webview-ui/src/components/chat/ChatTextArea.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -945,10 +945,10 @@ export const ChatTextArea = forwardRef<HTMLTextAreaElement, ChatTextAreaProps>(
className={cn(
"absolute",
"bottom-full",
isEditMode ? "left-6" : "left-0",
"left-0",
Copy link
Contributor Author

@roomote roomote bot Sep 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding a comment here explaining why we use consistent positioning instead of conditional logic based on isEditMode. This would help future maintainers understand the design decision and prevent regression.

Example:

"right-0",
"z-[1000]",
isEditMode ? "-mb-3" : "mb-2",
"mb-2",
Copy link
Contributor Author

@roomote roomote bot Sep 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this change correctly fixes the positioning issue, please verify that the ContextMenu still appears correctly in all usage scenarios:

  • Normal message input at bottom
  • Edit mode for existing messages
  • Different viewport sizes
  • With and without images attached

Consider adding visual regression tests or at least screenshots to the PR description showing the before/after comparison.

"filter",
"drop-shadow-md",
)}>
Expand Down
Loading