feat: add package.nls.json checking to find-missing-translations script

[roomote]

This PR addresses the issue where the find-missing-translations script was not checking the package.nls.json files for missing translations.

Changes Made

• Added a new "package-nls" area option to the find-missing-translations.js script
• Implemented checkPackageNlsTranslations() function to check all package.nls.*.json files against the base package.nls.json
• Updated the default area from "both" to "all" to include package-nls checks by default
• Added proper error handling and reporting for package.nls files

Testing

The script was tested and successfully detected 2 missing translation keys across all 17 language-specific package.nls files:

• commands.preventCompletionWithOpenTodos.description
• settings.newTaskRequireTodos.description

Usage

# Check only package.nls files
node scripts/find-missing-translations.js --area=package-nls

# Check all areas (core, webview, and package-nls)
node scripts/find-missing-translations.js --area=all

# Check specific locale
node scripts/find-missing-translations.js --area=package-nls --locale=fr

This enhancement ensures that all translation files, including the VSCode package.nls files, are properly checked for missing translations.

---

Important

Add package.nls.json checking to find-missing-translations.js script, including new area option and error handling.

• Behavior:
  • Added package-nls area option to find-missing-translations.js.
  • Implemented checkPackageNlsTranslations() to compare package.nls.*.json files against package.nls.json.
  • Default area changed from both to all to include package-nls by default.
  • Enhanced error handling for package.nls files.
• Testing:
  • Detected 2 missing translation keys across 17 language-specific package.nls files.
• Usage:
  • node scripts/find-missing-translations.js --area=package-nls to check only package.nls files.
  • node scripts/find-missing-translations.js --area=all to check all areas.
  • node scripts/find-missing-translations.js --area=package-nls --locale=fr to check a specific locale.

^{This description was created by for 496ce25. You can customize this summary. It will automatically update as commits are pushed.}

[roomote]

Reviewing my own code is like grading my own homework - suspiciously perfect yet somehow still needs work.

[brunobergher]

@roomote-agent implement the PR feedback.

[roomote]

Hi @brunobergher! I see the PR feedback and will implement the following improvements:

1. Extract shared JSON parsing utility - Reduce code duplication between checkAreaTranslations() and checkPackageNlsTranslations()
2. Add validation for flat JSON structure - Ensure package.nls files maintain the expected flat structure
3. Add warning message - Inform users when package.nls.json is not found
4. Performance optimization - Convert to async/await for parallel file reading

Working on these changes now!

[roomote]

Hi @brunobergher! I have successfully implemented all the PR feedback:

✅ Changes Implemented

1. Extracted shared JSON parsing utility (parseJsonFile)

   • Eliminates code duplication between checkAreaTranslations() and checkPackageNlsTranslations()
   • Provides consistent error handling across all file reads

2. Added validation for flat JSON structure

   • New validateFlatStructure() function ensures package.nls files maintain expected flat structure
   • Exits with error if nested objects are detected

3. Added warning message for missing package.nls.json

   • Now displays a clear warning when the base file is not found
   • Gracefully skips package.nls checks instead of erroring out

4. Converted to async/await for parallel file reading

   • All file operations now use async/await with Promise.all()
   • Significantly improves performance when checking multiple locales
   • Parallel processing of locale files and translation checks

📊 Test Results

The script is working correctly and detecting the 2 missing translation keys across all 17 language files:

• commands.preventCompletionWithOpenTodos.description
• settings.newTaskRequireTodos.description

The check-translations CI job is failing as expected due to these missing translations, which is the intended behavior to enforce translation completeness.

All other CI checks are passing successfully! 🎉

[daniel-lxs]

LGTM!