Skip to content

Conversation

@roomote
Copy link
Contributor

@roomote roomote bot commented Sep 24, 2025

This PR fixes issue #8278 by adding tooltips to display full file paths when they are truncated in narrow chat window layouts.

Problem

When file paths are long, they get truncated with ellipsis (...) in the chat UI, making it impossible to see the full path without resizing the chat window.

Solution

  • Added StandardTooltip wrapper to truncated file paths in ChatRow.tsx for file read operations
  • Added StandardTooltip wrapper to truncated file paths in BatchFilePermission.tsx for batch file permissions
  • Tooltips show the full file path (including any line snippets or reasons) when hovering over the truncated text

Testing

  • All existing tests pass (1082 tests passed)
  • Linting and type checking pass
  • Manual testing confirms tooltips appear correctly on hover

Fixes #8278


Important

Add tooltips to truncated file paths in ChatRow.tsx and BatchFilePermission.tsx to display full paths on hover.

  • Behavior:
    • Add StandardTooltip to truncated file paths in ChatRow.tsx for file read operations.
    • Add StandardTooltip to truncated file paths in BatchFilePermission.tsx for batch file permissions.
    • Tooltips display full file paths, including line snippets or reasons, on hover.
  • Testing:
    • All existing tests pass (1082 tests passed).
    • Linting and type checking pass.
    • Manual testing confirms tooltips appear correctly on hover.

This description was created by Ellipsis for 08cacea. You can customize this summary. It will automatically update as commits are pushed.

- Add StandardTooltip wrapper to truncated file paths in ChatRow.tsx
- Add StandardTooltip wrapper to truncated file paths in BatchFilePermission.tsx
- Shows full file path on hover when text is truncated with ellipsis
- Fixes #8278
@roomote roomote bot requested review from cte, jr and mrubens as code owners September 24, 2025 04:18
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. UI/UX UI/UX related or focused labels Sep 24, 2025
@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Sep 24, 2025
roomote[bot]

This comment was marked as outdated.

@daniel-lxs daniel-lxs moved this from Triage to PR [Needs Prelim Review] in Roo Code Roadmap Sep 24, 2025
@hannesrudolph hannesrudolph added PR - Needs Preliminary Review and removed Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. labels Sep 24, 2025
Copy link
Member

@daniel-lxs daniel-lxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test Review

{removeLeadingNonAlphanumeric(tool.path ?? "") + "\u200E"}
{tool.reason}
</span>
<StandardTooltip content={`${tool.path}${tool.reason ? ` ${tool.reason}` : ""}`}>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[P2] If tool.path is undefined the tooltip renders 'undefined'. Use a safe fallback and include an LRM to match the visible text’s directionality.

Suggested change
<StandardTooltip content={`${tool.path}${tool.reason ? ` ${tool.reason}` : ""}`}>
<StandardTooltip content={`${(tool.path ?? "")}${tool.reason ? ` ${tool.reason}` : ""}${(tool.path ?? "") || tool.reason ? "\u200E" : ""}`}>

{file.lineSnippet && ` ${file.lineSnippet}`}
</span>
<StandardTooltip
content={`${file.path}${file.lineSnippet ? ` ${file.lineSnippet}` : ""}`}>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[P2] Same issue here. Guard against undefined and add an LRM so the tooltip mirrors the RTL-safe rendering used for the visible text.

Suggested change
content={`${file.path}${file.lineSnippet ? ` ${file.lineSnippet}` : ""}`}>
<StandardTooltip content={`${(file.path ?? "")}${file.lineSnippet ? ` ${file.lineSnippet}` : ""}${(file.path ?? "") || file.lineSnippet ? "\u200E" : ""}`}>

@daniel-lxs daniel-lxs closed this Sep 25, 2025
@github-project-automation github-project-automation bot moved this from PR [Needs Prelim Review] to Done in Roo Code Roadmap Sep 25, 2025
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Sep 25, 2025
@daniel-lxs daniel-lxs deleted the fix/file-path-truncation-tooltip branch September 25, 2025 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR - Needs Preliminary Review size:S This PR changes 10-29 lines, ignoring generated files. UI/UX UI/UX related or focused

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

[BUG] Filename truncated in notice when chat is narrow

4 participants