-
Notifications
You must be signed in to change notification settings - Fork 2.6k
fix: include tool descriptions in custom system prompts for code-supernova #8308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Submodule Roo-Code
added at
86debe
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -194,9 +194,47 @@ export const SYSTEM_PROMPT = async ( | |
| }, | ||
| ) | ||
|
|
||
| // For file-based prompts, don't include the tool sections | ||
| // Get the full mode config to ensure we have the role definition (used for groups, etc.) | ||
| const modeConfig = getModeBySlug(mode, customModes) || modes.find((m) => m.slug === mode) || modes[0] | ||
|
|
||
| // Check if MCP functionality should be included | ||
| const hasMcpGroup = modeConfig.groups.some((groupEntry) => getGroupName(groupEntry) === "mcp") | ||
| const hasMcpServers = mcpHub && mcpHub.getServers().length > 0 | ||
| const shouldIncludeMcp = hasMcpGroup && hasMcpServers | ||
|
|
||
| // If diff is disabled, don't pass the diffStrategy | ||
| const effectiveDiffStrategy = diffEnabled ? diffStrategy : undefined | ||
|
|
||
| const codeIndexManager = CodeIndexManager.getInstance(context, cwd) | ||
|
|
||
| // Always include tool descriptions for file-based custom prompts | ||
| // This ensures models like code-supernova get the proper tool format | ||
| const toolDescriptions = getToolDescriptionsForMode( | ||
| mode, | ||
| cwd, | ||
| supportsComputerUse, | ||
| codeIndexManager, | ||
| effectiveDiffStrategy, | ||
| browserViewportSize, | ||
| shouldIncludeMcp ? mcpHub : undefined, | ||
| customModes, | ||
| experiments, | ||
| partialReadsEnabled, | ||
| settings, | ||
| enableMcpServerCreation, | ||
| modelId, | ||
| ) | ||
|
|
||
| return `${roleDefinition} | ||
|
|
||
| ${markdownFormattingSection()} | ||
|
|
||
| ${getSharedToolUseSection()} | ||
|
|
||
| ${toolDescriptions} | ||
|
|
||
| ${getToolUseGuidelinesSection(codeIndexManager)} | ||
|
|
||
| ${fileCustomSystemPrompt} | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. P2: The custom file-based prompt is appended after the Roo Tool Use sections. Consider placing the user’s custom prompt before tool/guidelines to preserve authorial context, or clarify precedence so Roo tool sections supersede overlapping instructions. |
||
|
|
||
| ${customInstructions}` | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P1: modeConfig.groups is accessed without a guard. A custom mode object may omit groups, causing a runtime error. Also applies to the earlier generatePrompt path.